Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: chrome/browser/cocoa/bookmark_bar_controller.h

Issue 437051: Mac: give visual feedback for bookmark button drags. (Closed)
Patch Set: Updated per pinkerton's review. Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/cocoa/bookmark_bar_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_bar_controller.h
diff --git a/chrome/browser/cocoa/bookmark_bar_controller.h b/chrome/browser/cocoa/bookmark_bar_controller.h
index 1f7bd8c281ae751bbc8a3f82d1a78073177cf6b6..e80cfa112797f8b50a45f1c1937fa084f9488ff3 100644
--- a/chrome/browser/cocoa/bookmark_bar_controller.h
+++ b/chrome/browser/cocoa/bookmark_bar_controller.h
@@ -167,11 +167,18 @@ willAnimateFromState:(bookmarks::VisualState)oldState
// need it for animations. Try not to propagate its use.
- (void)layoutSubviews;
-// Complete a drag of a bookmark button to this location on the main bar.
+// Complete a drag of a bookmark button to the given point (given in window
+// coordinates) on the main bar.
// TODO(jrg): submenu DnD.
// Returns YES on success.
- (BOOL)dragButton:(BookmarkButton*)sourceButton to:(NSPoint)point;
+// The x-coordinate of (the middle of) the indicator to draw for a drag of the
+// source button to the given point (given in window coordinates).
+// TODO(viettrungluu,jrg): instead of this, make buttons move around.
+- (CGFloat)indicatorPosForDragOfButton:(BookmarkButton*)sourceButton
+ toPoint:(NSPoint)point;
+
// Actions for manipulating bookmarks.
// From a button, ...
- (IBAction)openBookmark:(id)sender;
« no previous file with comments | « no previous file | chrome/browser/cocoa/bookmark_bar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698