Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Side by Side Diff: chrome/browser/cocoa/bookmark_bar_controller.h

Issue 437051: Mac: give visual feedback for bookmark button drags. (Closed)
Patch Set: Updated per pinkerton's review. Created 11 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/cocoa/bookmark_bar_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_COCOA_BOOKMARK_BAR_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_COCOA_BOOKMARK_BAR_CONTROLLER_H_
6 #define CHROME_BROWSER_COCOA_BOOKMARK_BAR_CONTROLLER_H_ 6 #define CHROME_BROWSER_COCOA_BOOKMARK_BAR_CONTROLLER_H_
7 7
8 #import <Cocoa/Cocoa.h> 8 #import <Cocoa/Cocoa.h>
9 #include <map> 9 #include <map>
10 10
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
160 - (CGFloat)toolbarDividerOpacity; 160 - (CGFloat)toolbarDividerOpacity;
161 161
162 // Returns true if at least one bookmark was added. 162 // Returns true if at least one bookmark was added.
163 - (BOOL)addURLs:(NSArray*)urls withTitles:(NSArray*)titles at:(NSPoint)point; 163 - (BOOL)addURLs:(NSArray*)urls withTitles:(NSArray*)titles at:(NSPoint)point;
164 164
165 // Updates the sizes and positions of the subviews. 165 // Updates the sizes and positions of the subviews.
166 // TODO(viettrungluu): I'm not convinced this should be public, but I currently 166 // TODO(viettrungluu): I'm not convinced this should be public, but I currently
167 // need it for animations. Try not to propagate its use. 167 // need it for animations. Try not to propagate its use.
168 - (void)layoutSubviews; 168 - (void)layoutSubviews;
169 169
170 // Complete a drag of a bookmark button to this location on the main bar. 170 // Complete a drag of a bookmark button to the given point (given in window
171 // coordinates) on the main bar.
171 // TODO(jrg): submenu DnD. 172 // TODO(jrg): submenu DnD.
172 // Returns YES on success. 173 // Returns YES on success.
173 - (BOOL)dragButton:(BookmarkButton*)sourceButton to:(NSPoint)point; 174 - (BOOL)dragButton:(BookmarkButton*)sourceButton to:(NSPoint)point;
174 175
176 // The x-coordinate of (the middle of) the indicator to draw for a drag of the
177 // source button to the given point (given in window coordinates).
178 // TODO(viettrungluu,jrg): instead of this, make buttons move around.
179 - (CGFloat)indicatorPosForDragOfButton:(BookmarkButton*)sourceButton
180 toPoint:(NSPoint)point;
181
175 // Actions for manipulating bookmarks. 182 // Actions for manipulating bookmarks.
176 // From a button, ... 183 // From a button, ...
177 - (IBAction)openBookmark:(id)sender; 184 - (IBAction)openBookmark:(id)sender;
178 - (IBAction)openFolderMenuFromButton:(id)sender; 185 - (IBAction)openFolderMenuFromButton:(id)sender;
179 // From a context menu over the button, ... 186 // From a context menu over the button, ...
180 - (IBAction)openBookmarkInNewForegroundTab:(id)sender; 187 - (IBAction)openBookmarkInNewForegroundTab:(id)sender;
181 - (IBAction)openBookmarkInNewWindow:(id)sender; 188 - (IBAction)openBookmarkInNewWindow:(id)sender;
182 - (IBAction)openBookmarkInIncognitoWindow:(id)sender; 189 - (IBAction)openBookmarkInIncognitoWindow:(id)sender;
183 - (IBAction)editBookmark:(id)sender; 190 - (IBAction)editBookmark:(id)sender;
184 - (IBAction)copyBookmark:(id)sender; 191 - (IBAction)copyBookmark:(id)sender;
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 - (int32)menuTagFromNodeId:(int64)menuid; 236 - (int32)menuTagFromNodeId:(int64)menuid;
230 - (void)buildOffTheSideMenu; 237 - (void)buildOffTheSideMenu;
231 - (NSMenu*)offTheSideMenu; 238 - (NSMenu*)offTheSideMenu;
232 - (NSButton*)offTheSideButton; 239 - (NSButton*)offTheSideButton;
233 - (NSButton*)otherBookmarksButton; 240 - (NSButton*)otherBookmarksButton;
234 - (BookmarkNode*)nodeFromMenuItem:(id)sender; 241 - (BookmarkNode*)nodeFromMenuItem:(id)sender;
235 - (void)updateTheme:(GTMTheme*)theme; 242 - (void)updateTheme:(GTMTheme*)theme;
236 @end 243 @end
237 244
238 #endif // CHROME_BROWSER_COCOA_BOOKMARK_BAR_CONTROLLER_H_ 245 #endif // CHROME_BROWSER_COCOA_BOOKMARK_BAR_CONTROLLER_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/cocoa/bookmark_bar_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698