Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 437013: Xcode has some issues with generated sources/headers and compiling sources. ... (Closed)

Created:
11 years, 1 month ago by TVL
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, sgk
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Xcode has some issues with generated sources/headers and compiling sources. This splits the actions/rules out into support targets to help coax Xcode into rebuilding when it should. There still seem to be some possible issues, but it does fix some fail cases we were able to create. Fix the case where test runners were not getting the configuration lists. TEST=everything still builds, and hopefully things do better at rebuilding when they should. BUG=none Committed revision 762.

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 6

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -40 lines) Patch
M pylib/gyp/generator/xcode.py View 1 2 3 4 15 chunks +80 lines, -40 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
TVL
I'm still watching this in my local tree for a few more builds, but I ...
11 years, 1 month ago (2009-11-23 19:16:18 UTC) #1
TVL
Ok, cl should be go, also fixed the issue with test runners not getting the ...
11 years, 1 month ago (2009-11-23 21:10:25 UTC) #2
sgk
Can the fail cases be captured in test case(s) that we can make part of ...
11 years, 1 month ago (2009-11-23 21:24:11 UTC) #3
Mark Mentovai
LGTM. Does this make us pass a test case that we wouldn't pass before, or ...
11 years, 1 month ago (2009-11-23 21:25:15 UTC) #4
TVL
On 2009/11/23 21:24:11, sgk wrote: > Can the fail cases be captured in test case(s) ...
11 years, 1 month ago (2009-11-23 21:35:43 UTC) #5
TVL
11 years, 1 month ago (2009-11-23 21:44:50 UTC) #6
comment/indent fixes up.

Powered by Google App Engine
This is Rietveld 408576698