Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 300016: Fix generators to make sure changes to rule inputs trigger correct rebuilds.... (Closed)

Created:
11 years, 2 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix generators to make sure changes to rule inputs trigger correct rebuilds. Currently disabled for MSVS and XCode. BUG=none TEST=none Committed: http://code.google.com/p/gyp/source/detail?r=763

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : disable on msvs, TODO issue 120 #

Patch Set 4 : add same_target.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -3 lines) Patch
M pylib/gyp/generator/make.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
A test/rules-rebuild/gyptest-all.py View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A test/rules-rebuild/gyptest-default.py View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
A test/rules-rebuild/src/main.c View 1 chunk +12 lines, -0 lines 0 comments Download
A test/rules-rebuild/src/make-sources.py View 1 chunk +15 lines, -0 lines 0 comments Download
A test/rules-rebuild/src/prog1.in View 1 chunk +7 lines, -0 lines 0 comments Download
A test/rules-rebuild/src/prog2.in View 1 chunk +7 lines, -0 lines 0 comments Download
A test/rules-rebuild/src/same_target.gyp View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sgk
Mark, could you take a look at this test configuration? It's a stripped-down case to ...
11 years, 2 months ago (2009-10-20 15:03:45 UTC) #1
Mark Mentovai
LGTM. TVL and I know that there's an Xcode bug here. I think it's timing-sensitive: ...
11 years, 2 months ago (2009-10-20 15:58:13 UTC) #2
sgk
11 years, 1 month ago (2009-11-23 23:21:21 UTC) #3
Didn't land this earlier because MSVS still has problems with it, too.  (Partly
the generator, partly test execution when cygwin has to be involved to run
make.)  I opened issue 120 to track that separately from the Xcode problem, and
will land it with MSVS execution disabled.

Powered by Google App Engine
This is Rietveld 408576698