Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 436843004: Move the user agent styles sheets to blink_resources.grd (Part 1) (Closed)

Created:
6 years, 4 months ago by vivekg_samsung
Modified:
6 years, 4 months ago
CC:
abarth-chromium, blink-reviews, dglazkov+blink, jamesr
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the user agent styles sheets to blink_resources.grd (Part 1) Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets. This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb. Part 2: https://codereview.chromium.org/422023008 Part 3: https://codereview.chromium.org/438843004/ BUG=312586 NOTRY=true TBR=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M public/blink_resources.grd View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
vivekg
PTAL, thank you.
6 years, 4 months ago (2014-08-01 18:17:36 UTC) #1
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-01 19:12:05 UTC) #2
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 4 months ago (2014-08-01 23:38:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/436843004/1
6 years, 4 months ago (2014-08-01 23:39:48 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-02 00:57:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-02 01:45:15 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20246)
6 years, 4 months ago (2014-08-02 01:45:16 UTC) #7
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 4 months ago (2014-08-02 02:51:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/436843004/1
6 years, 4 months ago (2014-08-02 02:52:21 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-02 03:32:31 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-02 04:46:42 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/20267)
6 years, 4 months ago (2014-08-02 04:46:43 UTC) #12
vivekg
The CQ bit was checked by vivekg@chromium.org
6 years, 4 months ago (2014-08-02 04:58:39 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/436843004/1
6 years, 4 months ago (2014-08-02 04:59:08 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 04:59:36 UTC) #15
Message was sent while issue was closed.
Change committed as 179437

Powered by Google App Engine
This is Rietveld 408576698