components/sync_driver/data_type_error_handler.h - Issue 436733002: [Sync] Use OnSingleDataTypeUnrecoverableError for all errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/data_type_error_handler.h

Issue 436733002: [Sync] Use OnSingleDataTypeUnrecoverableError for all errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync_driver/data_type_error_handler.h

diff --git a/components/sync_driver/data_type_error_handler.h b/components/sync_driver/data_type_error_handler.h

index a33a151f21718be62cc253289a92ffc8497315f8..174b9a8fdb89698e26f789999dd80d0550a51ca8 100644

--- a/components/sync_driver/data_type_error_handler.h

+++ b/components/sync_driver/data_type_error_handler.h

@@ -18,9 +18,8 @@ class DataTypeErrorHandler {

public:

// Call this to disable a datatype while it is running. This is usually

// called for a runtime failure that is specific to a datatype.

- virtual void OnSingleDatatypeUnrecoverableError(

- const tracked_objects::Location& from_here,

- const std::string& message) = 0;

+ virtual void OnSingleDataTypeUnrecoverableError(

+ const syncer::SyncError& error) = 0;

// This will create a syncer::SyncError object. This will also upload

// a breakpad call stack to crash server. A sync error usually means