Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 436713002: Pressing tab in overview should cycle windows. (Closed)

Created:
6 years, 4 months ago by rsadam
Modified:
6 years, 4 months ago
Reviewers:
flackr
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

This maps the tab key to have the same behaviour as the right arrow key. BUG=388745 TEST=WindowSelectorTest.BasicTabKeyNavigation Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287008

Patch Set 1 #

Patch Set 2 : Add unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
rsadam
6 years, 4 months ago (2014-07-31 20:20:37 UTC) #1
flackr
Should probably add a tab test, even though it is pretty trivial.
6 years, 4 months ago (2014-07-31 20:23:43 UTC) #2
rsadam
Done!
6 years, 4 months ago (2014-07-31 20:35:39 UTC) #3
flackr
Thanks, LGTM. Please add TEST=WindowSelectorTest.BasicTabKeyNavigation to CL description.
6 years, 4 months ago (2014-07-31 20:37:47 UTC) #4
rsadam
On 2014/07/31 20:37:47, flackr wrote: > Thanks, LGTM. Please add TEST=WindowSelectorTest.BasicTabKeyNavigation to CL > description. ...
6 years, 4 months ago (2014-07-31 20:38:41 UTC) #5
rsadam
Update: Based on offline discussions seems we can land this before M39.
6 years, 4 months ago (2014-07-31 20:44:41 UTC) #6
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 4 months ago (2014-07-31 20:44:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/436713002/20001
6 years, 4 months ago (2014-07-31 20:47:32 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-01 01:13:56 UTC) #9
rsadam
The CQ bit was unchecked by rsadam@chromium.org
6 years, 4 months ago (2014-08-01 12:48:35 UTC) #10
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 4 months ago (2014-08-01 12:48:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/436713002/20001
6 years, 4 months ago (2014-08-01 12:52:19 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 15:47:57 UTC) #13
Message was sent while issue was closed.
Change committed as 287008

Powered by Google App Engine
This is Rietveld 408576698