Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 436673004: Fix flaky cast_unittests where threads were being joined incorrectly. (Closed)

Created:
6 years, 4 months ago by miu
Modified:
6 years, 4 months ago
Reviewers:
Alpha Left Google
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix flaky cast_unittests where threads were being joined incorrectly. Root cause of the flakiness is that the StandaloneCastEnvironment, as a ref-counted object, was being destroyed on a thread other than the one that created it. At destruction, it attempted to join on the threads it owns, but these threads must be joined with the thread that they were spawned from. BUG=396480 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M media/cast/receiver/audio_decoder_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/cast/receiver/video_decoder_unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/cast/test/utility/standalone_cast_environment.h View 1 chunk +4 lines, -0 lines 0 comments Download
M media/cast/test/utility/standalone_cast_environment.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
miu
hubbe: PTAL.
6 years, 4 months ago (2014-07-31 22:56:02 UTC) #1
miu
hclam: PTAL.
6 years, 4 months ago (2014-08-01 20:16:42 UTC) #2
Alpha Left Google
lgtm
6 years, 4 months ago (2014-08-01 20:18:05 UTC) #3
miu
The CQ bit was checked by miu@chromium.org
6 years, 4 months ago (2014-08-01 20:22:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/436673004/1
6 years, 4 months ago (2014-08-01 20:24:53 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 11:19:46 UTC) #6
Message was sent while issue was closed.
Change committed as 287194

Powered by Google App Engine
This is Rietveld 408576698