Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: media/cast/receiver/audio_decoder_unittest.cc

Issue 436673004: Fix flaky cast_unittests where threads were being joined incorrectly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/cast/receiver/video_decoder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/receiver/audio_decoder_unittest.cc
diff --git a/media/cast/receiver/audio_decoder_unittest.cc b/media/cast/receiver/audio_decoder_unittest.cc
index 576e9dbce57ac67fb1cfe339a715ed4d5e679a4f..62e4fbbf616e0afc9485ab25a7480e1fbfbb86c3 100644
--- a/media/cast/receiver/audio_decoder_unittest.cc
+++ b/media/cast/receiver/audio_decoder_unittest.cc
@@ -35,6 +35,11 @@ class AudioDecoderTest : public ::testing::TestWithParam<TestScenario> {
: cast_environment_(new StandaloneCastEnvironment()),
cond_(&lock_) {}
+ virtual ~AudioDecoderTest() {
+ // Make sure all threads have stopped before the environment goes away.
+ cast_environment_->Shutdown();
+ }
+
protected:
virtual void SetUp() OVERRIDE {
audio_decoder_.reset(new AudioDecoder(cast_environment_,
« no previous file with comments | « no previous file | media/cast/receiver/video_decoder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698