Issue 43663005: crypto: Implement ECSignatureCreatorImpl for OpenSSL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 43663005: crypto: Implement ECSignatureCreatorImpl for OpenSSL (Closed)

Created:
7 years, 1 month ago by digit1

Modified:
7 years, 1 month ago

Reviewers:
agl, wtc, Ryan Sleevi

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

crypto: Implement ECSignatureCreatorImpl for OpenSSL BUG=306176 TEST=crypto_unittests --gtest_filter=ECSignatureCreatorTest.* R=rsleevi@chromium.org,agl@chromium.org,wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231048

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -17 lines)			Patch
	M	crypto/ec_signature_creator_openssl.cc	View		2 chunks	+59 lines, -6 lines	0 comments	Download
	M	crypto/ec_signature_creator_unittest.cc	View		2 chunks	+2 lines, -11 lines	0 comments	Download

Total messages: 5 (0 generated)

digit1

This is a simple re-upload of https://chromiumcodereview.appspot.com/26911006/ which apparently can't be submitted, even manually. I ...

7 years, 1 month ago (2013-10-25 13:23:29 UTC) #2

agl

Rubber stamp LGTM since I reviewed the previous upload of the same thing.

7 years, 1 month ago (2013-10-25 14:44:29 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/digit@chromium.org/43663005/1

7 years, 1 month ago (2013-10-25 15:20:01 UTC) #4

Message was sent while issue was closed.

Change committed as 231048