Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Unified Diff: crypto/ec_signature_creator_unittest.cc

Issue 43663005: crypto: Implement ECSignatureCreatorImpl for OpenSSL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « crypto/ec_signature_creator_openssl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crypto/ec_signature_creator_unittest.cc
diff --git a/crypto/ec_signature_creator_unittest.cc b/crypto/ec_signature_creator_unittest.cc
index bc0cb4a6b60d4a79872cd20a154b98f3686923fb..2a40cfe0c12a40f93dfa7f4db51f779de18b8663 100644
--- a/crypto/ec_signature_creator_unittest.cc
+++ b/crypto/ec_signature_creator_unittest.cc
@@ -12,17 +12,9 @@
#include "crypto/signature_verifier.h"
#include "testing/gtest/include/gtest/gtest.h"
-#if defined(USE_OPENSSL)
-// Once ECSignatureCreator is implemented for OpenSSL, remove this #if block.
-// TODO(rch): When that happens, also add some exported keys from each to
+// TODO(rch): Add some exported keys from each to
// test interop between NSS and OpenSSL.
-TEST(ECSignatureCreatorTest, OpenSSLStub) {
- scoped_ptr<crypto::ECSignatureCreator> signer(
- crypto::ECSignatureCreator::Create(NULL));
- ASSERT_TRUE(signer.get());
- EXPECT_FALSE(signer->Sign(NULL, 0, NULL));
-}
-#else
+
TEST(ECSignatureCreatorTest, BasicTest) {
// Do a verify round trip.
scoped_ptr<crypto::ECPrivateKey> key_original(
@@ -81,4 +73,3 @@ TEST(ECSignatureCreatorTest, BasicTest) {
data.size());
ASSERT_TRUE(verifier.VerifyFinal());
}
-#endif // !defined(USE_OPENSSL)
« no previous file with comments | « crypto/ec_signature_creator_openssl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698