Source/core/html/HTMLInputElement.cpp - Issue 436603003: Make Element::attributes() less error-prone and simplify call sites

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 436603003: Make Element::attributes() less error-prone and simplify call sites (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Keep synchronizeAllAttributes() in hasAttributes() Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index eac55fc56cef4d23d92e75f9c45a026bbe0161e7..a4aa1996013a96ebfa62b995976e4b872cc112ee 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -448,7 +448,7 @@ void HTMLInputElement::updateType()

if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttributes()) {

ASSERT(elementData());

- AttributeCollection attributes = this->attributes();

+ AttributeCollection attributes = this->attributesWithoutUpdate();

adamk 2014/08/04 18:54:34 Nit: you can drop |this| here.

Inactive 2014/08/04 19:39:52 Done.

if (const Attribute* height = attributes.find(heightAttr))

attributeChanged(heightAttr, height->value());

if (const Attribute* width = attributes.find(widthAttr))