Make Element::attributes() less error-prone and simplify call sites

Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 430 matching lines @@
         AtomicString valueString = fastGetAttribute(valueAttr);
         m_valueIfDirty = sanitizeValue(valueString);
     } else
         updateValueIfNeeded();
 
     m_needsToUpdateViewValue = true;
     m_inputTypeView->updateView();
 
     if (didRespectHeightAndWidth != m_inputType->shouldRespectHeightAndWidthAttributes()) {
         ASSERT(elementData());
-        AttributeCollection attributes = this->attributes();
+        AttributeCollection attributes = this->attributesWithoutUpdate();

[adamk, 2014/08/04 18:54:34]

Nit: you can drop |this| here.

[Inactive, 2014/08/04 19:39:52]

Done.

         if (const Attribute* height = attributes.find(heightAttr))
             attributeChanged(heightAttr, height->value());
         if (const Attribute* width = attributes.find(widthAttr))
             attributeChanged(widthAttr, width->value());
         if (const Attribute* align = attributes.find(alignAttr))
             attributeChanged(alignAttr, align->value());
     }
 
     if (document().focusedElement() == this)
         document().updateFocusAppearanceSoon(true /* restore selection */);
@@ skipping 1418 matching lines @@
 {
     return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue);
 }
 
 void HTMLInputElement::didNotifySubtreeInsertionsToDocument()
 {
     listAttributeTargetChanged();
 }
 
 } // namespace