Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 436563002: Remove value packing and custom style building for text-underline-position. (Closed)

Created:
6 years, 4 months ago by andersr
Modified:
6 years, 4 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove value packing and custom style building for text-underline-position. The user of this property (currently only computeUnderlineOffset) is oblivious to the fact that RenderStyle::textUnderlinePosition may be a packed value. (It looks like we'll ASSERT_NOT_REACHED if we actually pack values during style building). This was probably done in anticipation of the currently missing left|right values defined by CSS3 Text Decoration. I suggest that we remove the custom behavior until support for the properties are added. When/if support for left|right is added, it should probably go through StyleBuilderConverter anyway. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179384

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -22 lines) Patch
M Source/core/css/CSSProperties.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
andersr
Note: this is done on top of another patch: https://codereview.chromium.org/424683004/
6 years, 4 months ago (2014-07-31 12:51:12 UTC) #1
Timothy Loh
On 2014/07/31 12:51:12, andersr wrote: > Note: this is done on top of another patch: ...
6 years, 4 months ago (2014-08-01 00:21:46 UTC) #2
andersr
The CQ bit was checked by andersr@opera.com
6 years, 4 months ago (2014-08-01 08:53:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andersr@opera.com/436563002/1
6 years, 4 months ago (2014-08-01 08:54:51 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-01 10:00:46 UTC) #5
Message was sent while issue was closed.
Change committed as 179384

Powered by Google App Engine
This is Rietveld 408576698