Source/core/rendering/style/RenderStyleConstants.h - Issue 436563002: Remove value packing and custom style building for text-underline-position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/style/RenderStyleConstants.h

Issue 436563002: Remove value packing and custom style building for text-underline-position. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/style/RenderStyleConstants.h

diff --git a/Source/core/rendering/style/RenderStyleConstants.h b/Source/core/rendering/style/RenderStyleConstants.h

index cf8fa84727e02b995121be1f365c56e8b0602c15..185122c5bb5b6d30cb7ace4625b9918e6c42ee09 100644

--- a/Source/core/rendering/style/RenderStyleConstants.h

+++ b/Source/core/rendering/style/RenderStyleConstants.h

@@ -345,8 +345,8 @@ enum TextJustify {

enum TextUnderlinePosition {

// FIXME: Implement support for 'under left' and 'under right' values.

- TextUnderlinePositionAuto = 0x1,

- TextUnderlinePositionUnder = 0x2

+ TextUnderlinePositionAuto,

+ TextUnderlinePositionUnder

};

enum EPageBreak {

« no previous file with comments | « Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | Source/core/rendering/style/StyleRareInheritedData.h » ('j') | no next file with comments »