Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 436543002: Reduce potential flakyness of test by not requesting resize_ack. (Closed)

Created:
6 years, 4 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@makes_test_flaky
Project:
chromium
Visibility:
Public.

Description

Reduce potential flakyness of test by not requesting resize_ack. Having an empty new_size in the Resize event will prevent the renderer process to try to send a resize_ack. It reduces flakyness, making the test no longer rely on this timing. It should unblock https://codereview.chromium.org/134623005/ BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M content/browser/screen_orientation/screen_orientation_browsertest.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mlamouri (slow - plz ping)
6 years, 4 months ago (2014-07-31 12:40:52 UTC) #1
Michael van Ouwerkerk
lgtm
6 years, 4 months ago (2014-07-31 12:45:38 UTC) #2
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 4 months ago (2014-07-31 12:58:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/436543002/1
6 years, 4 months ago (2014-07-31 12:59:01 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 14:03:37 UTC) #5
Message was sent while issue was closed.
Change committed as 286804

Powered by Google App Engine
This is Rietveld 408576698