Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: content/browser/screen_orientation/screen_orientation_browsertest.cc

Issue 436543002: Reduce potential flakyness of test by not requesting resize_ack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@makes_test_flaky
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/screen_orientation/screen_orientation_browsertest.cc
diff --git a/content/browser/screen_orientation/screen_orientation_browsertest.cc b/content/browser/screen_orientation/screen_orientation_browsertest.cc
index 22c00567f65c223e394c76d50acbe706f0b33d87..40c372d22479edb20c8c2ac42781ab01cfd891de 100644
--- a/content/browser/screen_orientation/screen_orientation_browsertest.cc
+++ b/content/browser/screen_orientation/screen_orientation_browsertest.cc
@@ -30,17 +30,12 @@ class ScreenOrientationBrowserTest : public ContentBrowserTest {
virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
command_line->AppendSwitch(
switches::kEnableExperimentalWebPlatformFeatures);
- command_line->AppendSwitch(switches::kEnablePixelOutputInTests);
}
virtual void SetUp() OVERRIDE {
// Painting has to happen otherwise the Resize messages will be added on top
// of each other without properly ack-painting which will fail and crash.
UseSoftwareCompositing();
- EnablePixelOutput();
-
- // The browser process should not ack check, otherwise it will break.
- RenderWidgetHostImpl::DisableResizeAckCheckForTesting();
ContentBrowserTest::SetUp();
}
@@ -68,7 +63,7 @@ class ScreenOrientationBrowserTest : public ContentBrowserTest {
ViewMsg_Resize_Params params;
params.screen_info = screen_info;
- params.new_size = gfx::Size(300, 300);
+ params.new_size = gfx::Size(0, 0);
params.physical_backing_size = gfx::Size(300, 300);
params.overdraw_bottom_height = 0.f;
params.resizer_rect = gfx::Rect();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698