incremental progress reworking code completion manager / computers

pkg/analysis_server/test/domain_completion_test.dart

Index: pkg/analysis_server/test/domain_completion_test.dart
diff --git a/pkg/analysis_server/test/domain_completion_test.dart b/pkg/analysis_server/test/domain_completion_test.dart
index bc64d8f5bd4f898597f71ee2fe8116608ac16665..249df8f82fa7655bc42dc13305c97a3705515e94 100644
--- a/pkg/analysis_server/test/domain_completion_test.dart
+++ b/pkg/analysis_server/test/domain_completion_test.dart
@@ -17,6 +17,7 @@ import 'package:analysis_testing/reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 import 'analysis_abstract.dart';
+import 'mocks.dart';
 
 main() {
   groupSep = ' | ';
@@ -81,7 +82,7 @@ class CompletionTest extends AbstractAnalysisTest {
       Response response = handleSuccessfulRequest(request);
       completionId = response.getResult(ID);
       assertValidId(completionId);
-      return waitForSuggestions();
+      return pumpEventQueue();

[scheglov, 2014/08/04 17:00:30]

Why do we need this change?

If we don't use "suggestionsDone" anymore, should we remove it?

[danrubel, 2014/08/04 17:33:12]

This change prevents a test hang if a microtask throws an exception.
Good point. I need to assert that the last result has indeed been returned.
Fixed.

     });
   }
 
@@ -150,11 +151,4 @@ class CompletionTest extends AbstractAnalysisTest {
       assertNoResult('HtmlElement');
     });
   }
-
-  Future waitForSuggestions() {
-    if (suggestionsDone) {
-      return new Future.value();
-    }
-    return new Future.delayed(Duration.ZERO, waitForSuggestions);
-  }
 }