incremental progress reworking code completion manager / computers

pkg/analysis_server/test/domain_completion_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.domain.completion;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/domain_completion.dart';
 import 'package:analysis_server/src/protocol.dart';
 import 'package:analysis_services/completion/completion_suggestion.dart';
 import 'package:analysis_services/constants.dart';
 import 'package:analysis_services/index/index.dart' show Index;
 import 'package:analysis_services/index/local_memory_index.dart';
 import 'package:analysis_testing/reflective_tests.dart';
 import 'package:unittest/unittest.dart';
 
 import 'analysis_abstract.dart';
+import 'mocks.dart';
 
 main() {
   groupSep = ' | ';
   runReflectiveTests(CompletionTest);
 }
 
 @ReflectiveTestCase()
 class CompletionTest extends AbstractAnalysisTest {
   String completionId;
   int completionOffset;
@@ skipping 44 matching lines @@
   }
 
   Future getSuggestions() {
     return waitForTasksFinished().then((_) {
       Request request = new Request('0', COMPLETION_GET_SUGGESTIONS);
       request.setParameter(FILE, testFile);
       request.setParameter(OFFSET, completionOffset);
       Response response = handleSuccessfulRequest(request);
       completionId = response.getResult(ID);
       assertValidId(completionId);
-      return waitForSuggestions();
+      return pumpEventQueue();

[scheglov, 2014/08/04 17:00:30]

Why do we need this change?

If we don't use "suggestionsDone" anymore, should we remove it?

[danrubel, 2014/08/04 17:33:12]

This change prevents a test hang if a microtask throws an exception.
Good point. I need to assert that the last result has indeed been returned.
Fixed.

     });
   }
 
   void processNotification(Notification notification) {
     if (notification.event == COMPLETION_RESULTS) {
       String id = notification.getParameter(ID);
       assertValidId(id);
       if (id == completionId) {
         expect(suggestionsDone, isFalse);
         replacementOffset = notification.getParameter(REPLACEMENT_OFFSET);
@@ skipping 48 matching lines @@
       main() {tes^t}
     ''');
     return getSuggestions().then((_) {
 //      expect(replacementOffset, equals(completionOffset - 3));
 //      expect(replacementLength, equals(4));
       assertHasResult(CompletionSuggestionKind.CLASS, 'Object');
       assertHasResult(CompletionSuggestionKind.TOP_LEVEL_VARIABLE, 'test');
       assertNoResult('HtmlElement');
     });
   }
-
-  Future waitForSuggestions() {
-    if (suggestionsDone) {
-      return new Future.value();
-    }
-    return new Future.delayed(Duration.ZERO, waitForSuggestions);
-  }
 }