Migrate TestCommon to Chromium c++ style and remove un-used header.

content/shell/renderer/test_runner/TestPlugin.cpp

Index: content/shell/renderer/test_runner/TestPlugin.cpp
diff --git a/content/shell/renderer/test_runner/TestPlugin.cpp b/content/shell/renderer/test_runner/TestPlugin.cpp
index 3bd80a076e96bd44229f8f0033c59ee441250c8c..a42721b89623fbb07d3e2beb0211145e8db37621 100644
--- a/content/shell/renderer/test_runner/TestPlugin.cpp
+++ b/content/shell/renderer/test_runner/TestPlugin.cpp
@@ -8,8 +8,8 @@
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/shared_memory.h"
+#include "base/strings/stringprintf.h"
 #include "content/public/renderer/render_thread.h"
-#include "content/shell/renderer/test_runner/TestCommon.h"
 #include "content/shell/renderer/test_runner/WebTestDelegate.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/skia/include/core/SkCanvas.h"
@@ -87,14 +87,10 @@ const char* pointState(WebTouchPoint::State state)
 void printTouchList(WebTestDelegate* delegate, const WebTouchPoint* points, int length)
 {
     for (int i = 0; i < length; ++i) {
-        char buffer[100];
-        snprintf(buffer,
-                 sizeof(buffer),
-                 "* %.2f, %.2f: %s\n",
-                 points[i].position.x,
-                 points[i].position.y,
-                 pointState(points[i].state));
-        delegate->printMessage(buffer);
+      base::StringPrintf("* %.2f, %.2f: %s\n",
+                         points[i].position.x,
+                         points[i].position.y,
+                         pointState(points[i].state));

[Adam Rice, 2014/08/05 06:16:16]

Bug: delegate->printMessage() has gone missing. In fact, this statement now does
nothing. Also below.

[Abhishek, 2014/08/05 06:27:07]

sorry !
Are we still going to use snprintf here for this ?

[Adam Rice, 2014/08/05 06:31:56]

No. printMessage takes a string argument. Assign the output of StringPrintf to a
std::string, and then pass it to printMessage.

[Abhishek, 2014/08/05 07:22:49]

Done.

     }
 }
 
@@ -107,14 +103,10 @@ void printEventDetails(WebTestDelegate* delegate, const WebInputEvent& event)
         printTouchList(delegate, touch.targetTouches, touch.targetTouchesLength);
     } else if (WebInputEvent::isMouseEventType(event.type) || event.type == WebInputEvent::MouseWheel) {
         const WebMouseEvent& mouse = static_cast<const WebMouseEvent&>(event);
-        char buffer[100];
-        snprintf(buffer, sizeof(buffer), "* %d, %d\n", mouse.x, mouse.y);
-        delegate->printMessage(buffer);
+        base::StringPrintf("* %d, %d\n", mouse.x, mouse.y);
     } else if (WebInputEvent::isGestureEventType(event.type)) {
         const WebGestureEvent& gesture = static_cast<const WebGestureEvent&>(event);
-        char buffer[100];
-        snprintf(buffer, sizeof(buffer), "* %d, %d\n", gesture.x, gesture.y);
-        delegate->printMessage(buffer);
+        base::StringPrintf("* %d, %d\n", gesture.x, gesture.y);
     }
 }