Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 435913002: BitmapImage: Use the cheapest Vector constructor. (Closed)

Created:
6 years, 4 months ago by Daniel Bratell
Modified:
6 years, 3 months ago
Reviewers:
jamesr, Stephen White
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

BitmapImage: Use the cheapest Vector constructor. Vector() and Vector(0) will result in the same object but Vector() is cheaper (unless the optimizer manages to optimize away everything in Vector(size_t) ). BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181084

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 8 (0 generated)
Daniel Bratell
senorblanco, could you please take a look at this trivial change. Just something I stumbled ...
6 years, 4 months ago (2014-08-01 10:44:54 UTC) #1
Stephen White
LGTM Change seems harmless, but does this actually show up on any perf benchmarks?
6 years, 4 months ago (2014-08-04 14:59:20 UTC) #2
jamesr
https://codereview.chromium.org/435913002/diff/1/Source/platform/graphics/BitmapImage.cpp File Source/platform/graphics/BitmapImage.cpp (right): https://codereview.chromium.org/435913002/diff/1/Source/platform/graphics/BitmapImage.cpp#newcode47 Source/platform/graphics/BitmapImage.cpp:47: , m_frames() why not just remove this line completely?
6 years, 4 months ago (2014-08-07 17:38:30 UTC) #3
Daniel Bratell
On 2014/08/04 14:59:20, Stephen White wrote: > LGTM > > Change seems harmless, but does ...
6 years, 3 months ago (2014-08-26 09:04:46 UTC) #4
Daniel Bratell
https://codereview.chromium.org/435913002/diff/1/Source/platform/graphics/BitmapImage.cpp File Source/platform/graphics/BitmapImage.cpp (right): https://codereview.chromium.org/435913002/diff/1/Source/platform/graphics/BitmapImage.cpp#newcode47 Source/platform/graphics/BitmapImage.cpp:47: , m_frames() On 2014/08/07 17:38:29, jamesr wrote: > why ...
6 years, 3 months ago (2014-08-26 09:05:17 UTC) #5
Daniel Bratell
The CQ bit was checked by bratell@opera.com
6 years, 3 months ago (2014-08-29 08:41:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/435913002/1
6 years, 3 months ago (2014-08-29 08:42:43 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-08-29 09:47:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181084

Powered by Google App Engine
This is Rietveld 408576698