Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Side by Side Diff: Source/platform/graphics/BitmapImage.cpp

Issue 435913002: BitmapImage: Use the cheapest Vector constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 2 * Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
3 * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2005, 2006, 2008 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 26 matching lines...) Expand all
37 #include "wtf/CurrentTime.h" 37 #include "wtf/CurrentTime.h"
38 #include "wtf/PassRefPtr.h" 38 #include "wtf/PassRefPtr.h"
39 #include "wtf/Vector.h" 39 #include "wtf/Vector.h"
40 #include "wtf/text/WTFString.h" 40 #include "wtf/text/WTFString.h"
41 41
42 namespace WebCore { 42 namespace WebCore {
43 43
44 BitmapImage::BitmapImage(ImageObserver* observer) 44 BitmapImage::BitmapImage(ImageObserver* observer)
45 : Image(observer) 45 : Image(observer)
46 , m_currentFrame(0) 46 , m_currentFrame(0)
47 , m_frames(0) 47 , m_frames()
jamesr 2014/08/07 17:38:29 why not just remove this line completely?
Daniel Bratell 2014/08/26 09:05:17 It is a question of style, but in the work I've be
48 , m_frameTimer(0) 48 , m_frameTimer(0)
49 , m_repetitionCount(cAnimationNone) 49 , m_repetitionCount(cAnimationNone)
50 , m_repetitionCountStatus(Unknown) 50 , m_repetitionCountStatus(Unknown)
51 , m_repetitionsComplete(0) 51 , m_repetitionsComplete(0)
52 , m_desiredFrameStartTime(0) 52 , m_desiredFrameStartTime(0)
53 , m_frameCount(0) 53 , m_frameCount(0)
54 , m_isSolidColor(false) 54 , m_isSolidColor(false)
55 , m_checkedForSolidColor(false) 55 , m_checkedForSolidColor(false)
56 , m_animationFinished(false) 56 , m_animationFinished(false)
57 , m_allDataReceived(false) 57 , m_allDataReceived(false)
(...skipping 566 matching lines...) Expand 10 before | Expand all | Expand 10 after
624 } 624 }
625 return m_isSolidColor && !m_currentFrame; 625 return m_isSolidColor && !m_currentFrame;
626 } 626 }
627 627
628 Color BitmapImage::solidColor() const 628 Color BitmapImage::solidColor() const
629 { 629 {
630 return m_solidColor; 630 return m_solidColor;
631 } 631 }
632 632
633 } 633 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698