Navigation transitions: Plumb data from the outgoing renderer to the incoming renderer

content/common/frame_messages.h

Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index a28b7dd1cef41fc6246966aa08c9c016ff023708..489d46657a5770483f9fdcf562c296ed10f4bc02 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -382,6 +382,12 @@ IPC_MESSAGE_ROUTED2(FrameMsg_SetEditableSelectionOffsets,
                     int /* start */,
                     int /* end */)
 
+IPC_MESSAGE_ROUTED1(FrameMsg_SetupTransitionView,
+                    std::string /* markup */)
+
+IPC_MESSAGE_ROUTED1(FrameMsg_BeginExitTransition,
+                    std::string /* css_selector */)
+
 // Tells the renderer to reload the frame, optionally ignoring the cache while
 // doing so.
 IPC_MESSAGE_ROUTED1(FrameMsg_Reload,
@@ -681,9 +687,11 @@ IPC_MESSAGE_ROUTED3(FrameHostMsg_TextSurroundingSelectionResponse,
                     size_t /* endOffset */)
 
 // Notifies the browser that the renderer has a pending navigation transition.

[nasko, 2014/08/04 13:36:48]

nit: Add a comment saying that the strings are in UTF8 format.

[oystein (OOO til 10th of July), 2014/08/05 19:02:49]

Done.

-IPC_MESSAGE_CONTROL2(FrameHostMsg_SetHasPendingTransitionRequest,
+IPC_MESSAGE_CONTROL4(FrameHostMsg_AddNavigationTransitionData,
                      int /* render_frame_id */,
-                     bool /* is_transition */)
+                     std::string  /* origin */,

[nasko, 2014/08/04 13:36:48]

Any reason this is not a GURL?

[oystein (OOO til 10th of July), 2014/08/05 19:02:49]

The idea is that it can contain wildcards (*.google.com); can GURLS do that?

[nasko, 2014/08/06 10:58:49]

No, GURL doesn't support that. Then the name "origin" doesn't seem entirely
correct, as it is not an origin, but an origin/host pattern.

[oystein (OOO til 10th of July), 2014/08/06 22:36:19]

Yeah that makes sense. Renamed to allowed_destination_host_pattern.

+                     std::string  /* selector */,
+                     std::string  /* markup */)
 
 // Tells the browser to perform a navigation.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_BeginNavigation,