Navigation transitions: Plumb data from the outgoing renderer to the incoming renderer

content/common/frame_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for interacting with frames.
 // Multiply-included message file, hence no include guard.
 
 #include "content/common/content_export.h"
 #include "content/common/content_param_traits.h"
 #include "content/common/frame_message_enums.h"
@@ skipping 364 matching lines @@
                     base::string16,  /* javascript */
                     int,  /* ID */
                     bool  /* if true, a reply is requested */)
 
 // Selects between the given start and end offsets in the currently focused
 // editable field.
 IPC_MESSAGE_ROUTED2(FrameMsg_SetEditableSelectionOffsets,
                     int /* start */,
                     int /* end */)
 
+IPC_MESSAGE_ROUTED1(FrameMsg_SetupTransitionView,
+                    std::string /* markup */)
+
+IPC_MESSAGE_ROUTED1(FrameMsg_BeginExitTransition,
+                    std::string /* css_selector */)
+
 // Tells the renderer to reload the frame, optionally ignoring the cache while
 // doing so.
 IPC_MESSAGE_ROUTED1(FrameMsg_Reload,
                     bool /* ignore_cache */)
 
 // Notifies the color chooser client that the user selected a color.
 IPC_MESSAGE_ROUTED2(FrameMsg_DidChooseColorResponse, unsigned, SkColor)
 
 // Notifies the color chooser client that the color chooser has ended.
 IPC_MESSAGE_ROUTED1(FrameMsg_DidEndColorChooser, unsigned)
@@ skipping 278 matching lines @@
 IPC_MESSAGE_ROUTED1(FrameHostMsg_DidChangeThemeColor,
                     SkColor /* theme_color */)
 
 // Response for FrameMsg_TextSurroundingSelectionRequest, |startOffset| and
 // |endOffset| are the offsets of the selection in the returned |content|.
 IPC_MESSAGE_ROUTED3(FrameHostMsg_TextSurroundingSelectionResponse,
                     base::string16,  /* content */
                     size_t, /* startOffset */
                     size_t /* endOffset */)
 
 // Notifies the browser that the renderer has a pending navigation transition.

[nasko, 2014/08/04 13:36:48]

nit: Add a comment saying that the strings are in UTF8 format.

[oystein (OOO til 10th of July), 2014/08/05 19:02:49]

Done.

-IPC_MESSAGE_CONTROL2(FrameHostMsg_SetHasPendingTransitionRequest,
+IPC_MESSAGE_CONTROL4(FrameHostMsg_AddNavigationTransitionData,
                      int /* render_frame_id */,
-                     bool /* is_transition */)
+                     std::string  /* origin */,

[nasko, 2014/08/04 13:36:48]

Any reason this is not a GURL?

[oystein (OOO til 10th of July), 2014/08/05 19:02:49]

The idea is that it can contain wildcards (*.google.com); can GURLS do that?

[nasko, 2014/08/06 10:58:49]

No, GURL doesn't support that. Then the name "origin" doesn't seem entirely
correct, as it is not an origin, but an origin/host pattern.

[oystein (OOO til 10th of July), 2014/08/06 22:36:19]

Yeah that makes sense. Renamed to allowed_destination_host_pattern.

+                     std::string  /* selector */,
+                     std::string  /* markup */)
 
 // Tells the browser to perform a navigation.
 IPC_MESSAGE_ROUTED1(FrameHostMsg_BeginNavigation,
                     FrameHostMsg_BeginNavigation_Params)
 
 // Sent once a paint happens after the first non empty layout. In other words
 // after the frame has painted something.
 IPC_MESSAGE_ROUTED0(FrameHostMsg_DidFirstVisuallyNonEmptyPaint)