Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 435823002: Revert "Update webrtc&libjingle 6774:6799." (Closed)

Created:
6 years, 4 months ago by erikchen
Modified:
6 years, 4 months ago
Reviewers:
CC:
chromium-reviews, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert "Update webrtc&libjingle 6774:6799." This reverts commit bf45dff0ca703e5ad3bb6c6754ebdcb0c1b1296a. (https://codereview.chromium.org/429253003) Broke sizes on Linux http://build.chromium.org/p/chromium/builders/Linux/builds/51786 https://code.google.com/p/webrtc/source/browse/trunk/webrtc/base/linux.cc defines static std::string lsb_release_string; among other things It's guarded in WEBRTC_CHROMIUM_BUILDs. Maybe it should be WEBRTC_CHROMIUM_BUILD. BUG=NONE TBR=darin@chromium.org, hclam@chromium.org, jochen@chromium.org, palmer@chromium.org, sergeyu@chromium.org, wez@chromium.org, ronghuawu@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1609 lines, -943 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/BUILD.gn View 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_throttler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_throttler.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/p2p_messages.h View 4 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/media_stream_audio_processor_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.h View 2 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/mock_peer_connection_impl.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/media/peer_connection_identity_service.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/peer_connection_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_data_channel_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/media_stream_track_metrics.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_track_metrics_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/mock_peer_connection_dependency_factory.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.h View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_local_audio_track_adapter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_audio_capturer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_audio_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc_logging.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/host_address_request.h View 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/p2p/host_address_request.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/ipc_network_manager.cc View 4 chunks +21 lines, -21 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.h View 1 chunk +12 lines, -12 lines 0 comments Download
M content/renderer/p2p/ipc_socket_factory.cc View 23 chunks +69 lines, -69 lines 0 comments Download
M content/renderer/p2p/port_allocator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/p2p/port_allocator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/p2p/socket_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/socket_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/p2p/socket_client_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/glue/channel_socket_adapter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M jingle/glue/channel_socket_adapter.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M jingle/glue/channel_socket_adapter_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M jingle/glue/chrome_async_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/chrome_async_socket.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M jingle/glue/jingle_glue_mock_objects.h View 1 chunk +6 lines, -6 lines 0 comments Download
M jingle/glue/logging_unittest.cc View 7 chunks +41 lines, -41 lines 0 comments Download
M jingle/glue/mock_task.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/glue/mock_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/task_pump.h View 1 chunk +4 lines, -4 lines 0 comments Download
M jingle/glue/task_pump_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper.h View 4 chunks +21 lines, -21 lines 0 comments Download
M jingle/glue/thread_wrapper.cc View 10 chunks +32 lines, -32 lines 0 comments Download
M jingle/glue/thread_wrapper_unittest.cc View 12 chunks +23 lines, -23 lines 0 comments Download
M jingle/glue/utils.h View 2 chunks +4 lines, -4 lines 0 comments Download
M jingle/glue/utils.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M jingle/notifier/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M jingle/notifier/base/fake_base_task.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.h View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M jingle/notifier/base/weak_xmpp_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/base/weak_xmpp_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/weak_xmpp_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_connection.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/xmpp_connection_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M jingle/notifier/communicator/connection_settings.h View 3 chunks +3 lines, -3 lines 0 comments Download
M jingle/notifier/communicator/connection_settings.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M jingle/notifier/communicator/connection_settings_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M jingle/notifier/communicator/login.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M jingle/notifier/communicator/login_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/client/plugin/pepper_network_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/client/plugin/pepper_network_manager.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.h View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/client/plugin/pepper_packet_socket_factory.cc View 12 chunks +33 lines, -33 lines 0 comments Download
M remoting/client/plugin/pepper_port_allocator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_port_allocator.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M remoting/client/plugin/pepper_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/client/plugin/pepper_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/chromium_port_allocator_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromium_port_allocator_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/protocol/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/protocol/chromium_port_allocator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M remoting/protocol/chromium_port_allocator.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.h View 1 chunk +10 lines, -10 lines 0 comments Download
M remoting/protocol/chromium_socket_factory.cc View 11 chunks +42 lines, -42 lines 0 comments Download
M remoting/protocol/chromium_socket_factory_unittest.cc View 3 chunks +23 lines, -23 lines 0 comments Download
M remoting/protocol/jingle_messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/jingle_session_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/jingle_session_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/libjingle_transport_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/libjingle_transport_factory.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M remoting/protocol/message_decoder.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/message_reader_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/protocol/message_serialization.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/signaling/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/signaling/jingle_info_request.h View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/signaling/jingle_info_request.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/libjingle/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libjingle/libjingle.gyp View 9 chunks +25 lines, -29 lines 0 comments Download
M third_party/libjingle/libjingle_common.gypi View 2 chunks +204 lines, -0 lines 0 comments Download
M third_party/libjingle/libjingle_nacl.gyp View 4 chunks +0 lines, -190 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/libjingle/overrides/init_webrtc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/libjingle/overrides/initialize_module.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A third_party/libjingle/overrides/talk/base/basictypes.h View 1 chunk +102 lines, -0 lines 0 comments Download
A third_party/libjingle/overrides/talk/base/constructormagic.h View 1 chunk +14 lines, -0 lines 0 comments Download
A third_party/libjingle/overrides/talk/base/logging.h View 1 chunk +215 lines, -0 lines 0 comments Download
A third_party/libjingle/overrides/talk/base/logging.cc View 1 chunk +311 lines, -0 lines 0 comments Download
A third_party/libjingle/overrides/talk/base/win32socketinit.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
erikchen
The CQ bit was checked by erikchen@chromium.org
6 years, 4 months ago (2014-07-31 23:44:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikchen@chromium.org/435823002/1
6 years, 4 months ago (2014-07-31 23:47:09 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 23:50:16 UTC) #3
Message was sent while issue was closed. 
Change committed as 286914

Powered by Google App Engine
This is Rietveld 408576698