DevTools: Async call stacks for FileSystem API part 1 (second try).

DevTools: Async call stacks for FileSystem API part 1 (second try).

This uses a simpler instrumentation API.
First try was in r178149.

BUG=272416, 390863
R=yurys, pfeldman

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179585

[yurys, 2014-08-05 15:44:10]

lgtm

https://codereview.chromium.org/435423004/diff/1/Source/modules/filesystem/DO...
File Source/modules/filesystem/DOMFileSystem.h (right):

https://codereview.chromium.org/435423004/diff/1/Source/modules/filesystem/DO...
Source/modules/filesystem/DOMFileSystem.h:117: return m_taskName;
Maybe just
 return "FileSystem";
?

[aandrey, 2014-08-05 15:46:18]

https://codereview.chromium.org/435423004/diff/1/Source/modules/filesystem/DO...
File Source/modules/filesystem/DOMFileSystem.h (right):

https://codereview.chromium.org/435423004/diff/1/Source/modules/filesystem/DO...
Source/modules/filesystem/DOMFileSystem.h:117: return m_taskName;
On 2014/08/05 15:44:09, yurys wrote:
> Maybe just
>  return "FileSystem";
> ?

We can not return a stack allocated var by pointer/reference, can we?

[aandrey, 2014-08-05 15:46:27]

The CQ bit was checked by aandrey@chromium.org

[yurys, 2014-08-05 15:48:28]

https://codereview.chromium.org/435423004/diff/1/Source/modules/filesystem/DO...
File Source/modules/filesystem/DOMFileSystem.h (right):

https://codereview.chromium.org/435423004/diff/1/Source/modules/filesystem/DO...
Source/modules/filesystem/DOMFileSystem.h:117: return m_taskName;
On 2014/08/05 15:46:18, aandrey wrote:
> On 2014/08/05 15:44:09, yurys wrote:
> > Maybe just
> >  return "FileSystem";
> > ?
> 
> We can not return a stack allocated var by pointer/reference, can we?
Oh, missed that again, I still think that taskNameForInstrumentation should
return String by value.

[commit-bot: I haz the power, 2014-08-05 15:49:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/435423004/1

[aandrey, 2014-08-05 15:49:07]

The CQ bit was unchecked by aandrey@chromium.org

[aandrey, 2014-08-05 15:50:30]

need owner stamp on filesystem/

[kinuko, 2014-08-06 06:40:25]

rslgtm

[aandrey, 2014-08-06 07:17:33]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-08-06 07:18:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/435423004/1

[commit-bot: I haz the power, 2014-08-06 08:30:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-08-06 08:49:01]

Change committed as 179585