DevTools: Async call stacks for FileSystem API part 1 (second try).

Source/modules/filesystem/DOMFileSystem.h

Index: Source/modules/filesystem/DOMFileSystem.h
diff --git a/Source/modules/filesystem/DOMFileSystem.h b/Source/modules/filesystem/DOMFileSystem.h
index fe88886e1262425bc00234f29ae12a04dff5bc41..995778fb08e5f9b71c3f89c4d7139f082348a27c 100644
--- a/Source/modules/filesystem/DOMFileSystem.h
+++ b/Source/modules/filesystem/DOMFileSystem.h
@@ -105,9 +105,25 @@ public:
 private:
     DOMFileSystem(ExecutionContext*, const String& name, FileSystemType, const KURL& rootURL);
 
+    class DispatchCallbackTaskBase : public ExecutionContextTask {
+    public:
+        DispatchCallbackTaskBase()
+            : m_taskName("FileSystem")
+        {
+        }
+
+        virtual const String& taskNameForInstrumentation() const OVERRIDE
+        {
+            return m_taskName;

[yurys, 2014/08/05 15:44:09]

Maybe just
 return "FileSystem";
?

[aandrey, 2014/08/05 15:46:18]

We can not return a stack allocated var by pointer/reference, can we?

[yurys, 2014/08/05 15:48:27]

Oh, missed that again, I still think that taskNameForInstrumentation should
return String by value.

+        }
+
+    private:
+        const String m_taskName;
+    };
+
     // A helper template to schedule a callback task.
     template <typename CB, typename CBArg>
-    class DispatchCallbackRefPtrArgTask FINAL : public ExecutionContextTask {
+    class DispatchCallbackRefPtrArgTask FINAL : public DispatchCallbackTaskBase {
     public:
         DispatchCallbackRefPtrArgTask(PassOwnPtr<CB> callback, PassRefPtrWillBeRawPtr<CBArg> arg)
             : m_callback(callback)
@@ -126,7 +142,7 @@ private:
     };
 
     template <typename CB, typename CBArg>
-    class DispatchCallbackPtrArgTask FINAL : public ExecutionContextTask {
+    class DispatchCallbackPtrArgTask FINAL : public DispatchCallbackTaskBase {
     public:
         DispatchCallbackPtrArgTask(PassOwnPtr<CB> callback, CBArg* arg)
             : m_callback(callback)
@@ -145,7 +161,7 @@ private:
     };
 
     template <typename CB, typename CBArg>
-    class DispatchCallbackNonPtrArgTask FINAL : public ExecutionContextTask {
+    class DispatchCallbackNonPtrArgTask FINAL : public DispatchCallbackTaskBase {
     public:
         DispatchCallbackNonPtrArgTask(PassOwnPtr<CB> callback, const CBArg& arg)
             : m_callback(callback)
@@ -164,7 +180,7 @@ private:
     };
 
     template <typename CB>
-    class DispatchCallbackNoArgTask FINAL : public ExecutionContextTask {
+    class DispatchCallbackNoArgTask FINAL : public DispatchCallbackTaskBase {
     public:
         DispatchCallbackNoArgTask(PassOwnPtr<CB> callback)
             : m_callback(callback)