Remove <if> statements before checking JS code by checker.py

Remove <if> statements before checking JS code by checker.py

BUG=393873
TEST=./third_party/closure_compiler/checker_test.py
R=dbeam@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287195

[Vitaly Pavlenko, 2014-08-01 19:57:10]

The CQ bit was checked by vitalyp@chromium.org

[Vitaly Pavlenko, 2014-08-01 19:57:10]

The CQ bit was unchecked by vitalyp@chromium.org

[Dan Beam, 2014-08-01 20:39:54]

https://codereview.chromium.org/435053002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/checker.py (right):

https://codereview.chromium.org/435053002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/checker.py:50: self.lines =
map(self._remove_if_operators, self.lines)
for line in self.lines:
  line[2] = re.sub(self._IF_TAGS_REG, "", line[2])

[Vitaly Pavlenko, 2014-08-01 20:52:38]

https://codereview.chromium.org/435053002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/checker.py (right):

https://codereview.chromium.org/435053002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/checker.py:50: self.lines =
map(self._remove_if_operators, self.lines)
On 2014/08/01 20:39:54, Dan Beam wrote:
> for line in self.lines:
>   line[2] = re.sub(self._IF_TAGS_REG, "", line[2])

    line[2] = re.sub(self._IF_TAGS_REG, "", line[2])
TypeError: 'tuple' object does not support item assignment

So I can inline, but it will look like 

    for i, line in enumerate(self.lines):
      self.lines[i] = line[:2] + (re.sub(self._IF_TAGS_REG, "", line[2]),)

[Dan Beam, 2014-08-01 20:59:53]

https://codereview.chromium.org/435053002/diff/1/third_party/closure_compiler...
File third_party/closure_compiler/checker.py (right):

https://codereview.chromium.org/435053002/diff/1/third_party/closure_compiler...
third_party/closure_compiler/checker.py:50: self.lines =
map(self._remove_if_operators, self.lines)
On 2014/08/01 20:52:37, Vitaly Pavlenko wrote:
> On 2014/08/01 20:39:54, Dan Beam wrote:
> > for line in self.lines:
> >   line[2] = re.sub(self._IF_TAGS_REG, "", line[2])
> 
>     line[2] = re.sub(self._IF_TAGS_REG, "", line[2])
> TypeError: 'tuple' object does not support item assignment
> 
> So I can inline, but it will look like 
> 
>     for i, line in enumerate(self.lines):
>       self.lines[i] = line[:2] + (re.sub(self._IF_TAGS_REG, "", line[2]),)

^ that's fine

[Vitaly Pavlenko, 2014-08-01 21:16:14]

Created Patch Set 2

[Dan Beam, 2014-08-02 00:04:56]

lgtm

https://codereview.chromium.org/435053002/diff/20001/third_party/closure_comp...
File third_party/closure_compiler/checker.py (right):

https://codereview.chromium.org/435053002/diff/20001/third_party/closure_comp...
third_party/closure_compiler/checker.py:51: # with an empty string.
^ i think the code pretty clearly shows this, but sure

[commit-bot: I haz the power, 2014-08-02 00:06:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vitalyp@chromium.org/435053002/20001

[commit-bot: I haz the power, 2014-08-02 11:25:34]

Change committed as 287195