Remove <if> statements before checking JS code by checker.py

third_party/closure_compiler/checker.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from collections import defaultdict
 import os
 import re
 import subprocess
 import sys
 import tempfile
@@ skipping 13 matching lines @@
     file = os.path.abspath(file)
     self._cache[file] = self._cache[file] or open(file, "r").read()
     return self._cache[file]
 
   @staticmethod
   def read(file):
     return FileCache()._read(file)
 
 
 class Flattener(object):
+  _IF_TAGS_REG = "</?if[^>]*?>"
   _INCLUDE_REG = "<include[^>]+src=['\"]([^>]*)['\"]>"
 
   def __init__(self, file):
     self.index = 0
     self.lines = self._get_file(file)
 
     while self.index < len(self.lines):
       current_line = self.lines[self.index]
       match = re.search(self._INCLUDE_REG, current_line[2])
       if match:
         file_dir = os.path.dirname(current_line[0])
         self._inline_file(os.path.join(file_dir, match.group(1)))
       else:
         self.index += 1
 
+    self.lines = map(self._remove_if_operators, self.lines)

[Dan Beam, 2014/08/01 20:39:54]

for line in self.lines:
  line[2] = re.sub(self._IF_TAGS_REG, "", line[2])

[Vitaly Pavlenko, 2014/08/01 20:52:37]

    line[2] = re.sub(self._IF_TAGS_REG, "", line[2])
TypeError: 'tuple' object does not support item assignment

So I can inline, but it will look like 

    for i, line in enumerate(self.lines):
      self.lines[i] = line[:2] + (re.sub(self._IF_TAGS_REG, "", line[2]),)

[Dan Beam, 2014/08/01 20:59:53]

^ that's fine

+
     self.contents = "\n".join(l[2] for l in self.lines)
 
+  def _remove_if_operators(self, line):
+    # Replace every occurrence of tags like <if expr="..."> and </if>
+    # with an empty string.
+    file, lnum, contents = line
+    contents = re.sub(self._IF_TAGS_REG, '', contents)
+    return (file, lnum, contents)
+  
   # Returns a list of tuples in the format: (file, line number, line contents).
   def _get_file(self, file):
     lines = FileCache.read(file).splitlines()
     return [(file, lnum + 1, line) for lnum, line in enumerate(lines)]
 
   def _inline_file(self, file):
     lines = self._get_file(file)
     self.lines = self.lines[:self.index] + lines + self.lines[self.index + 1:]
 
   def get_file_from_line(self, line_number):
@@ skipping 155 matching lines @@
     output = self._format_errors(map(self._fix_up_error, errors))
 
     if runner_cmd.returncode:
       self._error("Error in: " + file + ("\n" + output if output else ""))
     elif output:
       self._debug("Output: " + output)
 
     self._clean_up()
 
     return runner_cmd.returncode, output