Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 435023002: Revert "Revert 285479 "Make DataSource::Stop() synchronous."" (Closed)

Created:
6 years, 4 months ago by xhwang
Modified:
6 years, 4 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert "Revert 285479 "Make DataSource::Stop() synchronous."" This reverts commit aca48d3efdf5ba8a891d6f139fd8ba8db8d69fc2. The original CL didn't cause issue 397656. It's caused by previous CLs and is fixed by r286787. This CL simply reland the original CL. TBR=gbillock@chromium.org BUG=349211, 397656 TEST=Existing tests pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -75 lines) Patch
M chrome/utility/media_galleries/ipc_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/media_galleries/ipc_data_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/buffered_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/buffered_data_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/buffered_data_source_unittest.cc View 3 chunks +2 lines, -27 lines 0 comments Download
M media/base/data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/blocking_url_protocol_unittest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M media/filters/ffmpeg_demuxer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 2 chunks +15 lines, -21 lines 0 comments Download
M media/filters/file_data_source.h View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/file_data_source.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/filters/file_data_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/data_source_logger.h View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/data_source_logger.cc View 2 chunks +3 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xhwang
PTAL
6 years, 4 months ago (2014-08-01 20:17:49 UTC) #1
scherkus (not reviewing)
lgtm
6 years, 4 months ago (2014-08-01 20:35:06 UTC) #2
xhwang
TBRing gbillock@chromium.org
6 years, 4 months ago (2014-08-01 23:15:00 UTC) #3
xhwang
The CQ bit was checked by xhwang@chromium.org
6 years, 4 months ago (2014-08-01 23:15:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/435023002/1
6 years, 4 months ago (2014-08-01 23:16:08 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-02 00:42:18 UTC) #6
Message was sent while issue was closed. 
Change committed as 287136

Powered by Google App Engine
This is Rietveld 408576698