chrome/utility/media_galleries/ipc_data_source.cc - Issue 435023002: Revert "Revert 285479 "Make DataSource::Stop() synchronous.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/media_galleries/ipc_data_source.cc

Issue 435023002: Revert "Revert 285479 "Make DataSource::Stop() synchronous."" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/utility/media_galleries/ipc_data_source.cc

diff --git a/chrome/utility/media_galleries/ipc_data_source.cc b/chrome/utility/media_galleries/ipc_data_source.cc

index c44670a3c698aae8cf259c3d44a69eed8b5bb836..c65a89826a0111d194b65a46bce754e7868c5fce 100644

--- a/chrome/utility/media_galleries/ipc_data_source.cc

+++ b/chrome/utility/media_galleries/ipc_data_source.cc

@@ -21,9 +21,8 @@ IPCDataSource::~IPCDataSource() {

DCHECK(utility_thread_checker_.CalledOnValidThread());

}

-void IPCDataSource::Stop(const base::Closure& callback) {

+void IPCDataSource::Stop() {

DCHECK(data_source_thread_checker_.CalledOnValidThread());

- callback.Run();

}

void IPCDataSource::Read(int64 position, int size, uint8* data,