Issue 435014: Merge 32889 - Fix crash when an extension popup shows a JS alert. Showing the...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 435014: Merge 32889 - Fix crash when an extension popup shows a JS alert. Showing the... (Closed)

Created:
11 years, 1 month ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
rafaelw

CC:
chromium-reviews_googlegroups.com, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, brettw+cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/249/src/

Visibility:
Public.

Description

Merge 32889 - Fix crash when an extension popup shows a JS alert. Showing the alert takes... Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show. Disable showing JS alerts from popups, because doing so makes the popup disappear immediately, which has all sorts of unfortunate side effects for the poor orphaned alert (see bug for details). BUG=27758 TEST=create extension with popup, put link with |onclick="alert('test');"| in it; install extension, open popup, and click link; see no crash (nor popup) Review URL: http://codereview.chromium.org/435010 TBR=rafaelw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32900

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+76 lines, -39 lines)			Patch
M	chrome/browser/app_modal_dialog.h	View	3 chunks	+11 lines, -2 lines	0 comments	Download
M	chrome/browser/app_modal_dialog.cc	View	6 chunks	+47 lines, -23 lines	0 comments	Download
M	chrome/browser/extensions/extension_host.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/jsmessage_box_client.h	View	2 chunks	+6 lines, -3 lines	0 comments	Download
MM	chrome/browser/tab_contents/tab_contents.h	View	2 chunks	+11 lines, -11 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages