Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: chrome/browser/tab_contents/tab_contents.h

Issue 435014: Merge 32889 - Fix crash when an extension popup shows a JS alert. Showing the... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/249/src/
Patch Set: Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/jsmessage_box_client.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Property Changes:
Deleted: svn:mergeinfo
Reverse-merged /branches/chrome_webkit_merge_branch/chrome/browser/tab_contents.h:r69-2775
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 5 #ifndef CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
6 #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 6 #define CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
7 7
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 9
10 #include <map> 10 #include <map>
(...skipping 604 matching lines...) Expand 10 before | Expand all | Expand 10 after
615 // Set the time when we started to create the new tab page. This time is 615 // Set the time when we started to create the new tab page. This time is
616 // from before we created this TabContents. 616 // from before we created this TabContents.
617 void set_new_tab_start_time(const base::TimeTicks& time) { 617 void set_new_tab_start_time(const base::TimeTicks& time) {
618 new_tab_start_time_ = time; 618 new_tab_start_time_ = time;
619 } 619 }
620 620
621 // Notification that tab closing has started. This can be called multiple 621 // Notification that tab closing has started. This can be called multiple
622 // times, subsequent calls are ignored. 622 // times, subsequent calls are ignored.
623 void OnCloseStarted(); 623 void OnCloseStarted();
624 624
625 // JavaScriptMessageBoxClient ------------------------------------------------
626 virtual std::wstring GetMessageBoxTitle(const GURL& frame_url,
627 bool is_alert);
628 virtual gfx::NativeWindow GetMessageBoxRootWindow();
629 virtual void OnMessageBoxClosed(IPC::Message* reply_msg,
630 bool success,
631 const std::wstring& prompt);
632 virtual void SetSuppressMessageBoxes(bool suppress_message_boxes);
633 virtual TabContents* AsTabContents() { return this; }
634 virtual ExtensionHost* AsExtensionHost() { return NULL; }
635
625 private: 636 private:
626 friend class NavigationController; 637 friend class NavigationController;
627 // Used to access the child_windows_ (ConstrainedWindowList) for testing 638 // Used to access the child_windows_ (ConstrainedWindowList) for testing
628 // automation purposes. 639 // automation purposes.
629 friend class AutomationProvider; 640 friend class AutomationProvider;
630 friend class BlockedPopupContainerTest; 641 friend class BlockedPopupContainerTest;
631 friend class BlockedPopupContainerControllerTest; 642 friend class BlockedPopupContainerControllerTest;
632 643
633 FRIEND_TEST(BlockedPopupContainerTest, TestReposition); 644 FRIEND_TEST(BlockedPopupContainerTest, TestReposition);
634 FRIEND_TEST(TabContentsTest, NoJSMessageOnInterstitials); 645 FRIEND_TEST(TabContentsTest, NoJSMessageOnInterstitials);
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
956 // InitWithExistingID. 967 // InitWithExistingID.
957 virtual bool CreateRenderViewForRenderManager( 968 virtual bool CreateRenderViewForRenderManager(
958 RenderViewHost* render_view_host); 969 RenderViewHost* render_view_host);
959 970
960 // NotificationObserver ------------------------------------------------------ 971 // NotificationObserver ------------------------------------------------------
961 972
962 virtual void Observe(NotificationType type, 973 virtual void Observe(NotificationType type,
963 const NotificationSource& source, 974 const NotificationSource& source,
964 const NotificationDetails& details); 975 const NotificationDetails& details);
965 976
966
967 // JavaScriptMessageBoxClient ------------------------------------------------
968 virtual std::wstring GetMessageBoxTitle(const GURL& frame_url,
969 bool is_alert);
970 virtual gfx::NativeWindow GetMessageBoxRootWindow();
971 virtual void OnMessageBoxClosed(IPC::Message* reply_msg,
972 bool success,
973 const std::wstring& prompt);
974 virtual void SetSuppressMessageBoxes(bool suppress_message_boxes);
975 virtual TabContents* AsTabContents() { return this; }
976
977 // Data for core operation --------------------------------------------------- 977 // Data for core operation ---------------------------------------------------
978 978
979 // Delegate for notifying our owner about stuff. Not owned by us. 979 // Delegate for notifying our owner about stuff. Not owned by us.
980 TabContentsDelegate* delegate_; 980 TabContentsDelegate* delegate_;
981 981
982 // Handles the back/forward list and loading. 982 // Handles the back/forward list and loading.
983 NavigationController controller_; 983 NavigationController controller_;
984 984
985 // The corresponding view. 985 // The corresponding view.
986 scoped_ptr<TabContentsView> view_; 986 scoped_ptr<TabContentsView> view_;
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
1178 1178
1179 // The time that we started to close the tab. 1179 // The time that we started to close the tab.
1180 base::TimeTicks tab_close_start_time_; 1180 base::TimeTicks tab_close_start_time_;
1181 1181
1182 // --------------------------------------------------------------------------- 1182 // ---------------------------------------------------------------------------
1183 1183
1184 DISALLOW_COPY_AND_ASSIGN(TabContents); 1184 DISALLOW_COPY_AND_ASSIGN(TabContents);
1185 }; 1185 };
1186 1186
1187 #endif // CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_ 1187 #endif // CHROME_BROWSER_TAB_CONTENTS_TAB_CONTENTS_H_
OLDNEW
« no previous file with comments | « chrome/browser/jsmessage_box_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698