Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 435010: Fix crash when an extension popup shows a JS alert. Showing the alert takes... (Closed)

Created:
11 years, 1 month ago by rafaelw
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix crash when an extension popup shows a JS alert. Showing the alert takes... Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show. Disable showing JS alerts from popups, because doing so makes the popup disappear immediately, which has all sorts of unfortunate side effects for the poor orphaned alert (see bug for details). BUG=27758 TEST=create extension with popup, put link with |onclick="alert('test');"| in it; install extension, open popup, and click link; see no crash (nor popup) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32889

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -39 lines) Patch
M chrome/browser/app_modal_dialog.h View 3 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/app_modal_dialog.cc View 6 chunks +47 lines, -23 lines 0 comments Download
M chrome/browser/extensions/extension_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/jsmessage_box_client.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 2 chunks +11 lines, -11 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698