chrome/browser/extensions/extension_host.h - Issue 435010: Fix crash when an extension popup shows a JS alert. Showing the alert takes...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_host.h

Issue 435010: Fix crash when an extension popup shows a JS alert. Showing the alert takes... (Closed)

Patch Set: Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_host.h

diff --git a/chrome/browser/extensions/extension_host.h b/chrome/browser/extensions/extension_host.h

index 9407b85f36e976a46df310b97bb219dc01948792..e3ae6806718119c6976b95f2060eebe5216faf6d 100644

--- a/chrome/browser/extensions/extension_host.h

+++ b/chrome/browser/extensions/extension_host.h

@@ -156,6 +156,7 @@ class ExtensionHost : public ExtensionPopupHost::PopupDelegate,

const std::wstring& prompt);

virtual void SetSuppressMessageBoxes(bool suppress_message_boxes) {}

virtual TabContents* AsTabContents() { return NULL; }

+ virtual ExtensionHost* AsExtensionHost() { return this; }

private:

friend class ProcessCreationQueue;

« no previous file with comments | « chrome/browser/app_modal_dialog.cc ('k') | chrome/browser/jsmessage_box_client.h » ('j') | no next file with comments »