Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 434823002: Remove mocking from DataObjectTest.cpp (Closed)

Created:
6 years, 4 months ago by pwnall-personal
Modified:
6 years, 4 months ago
Reviewers:
tkent, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove mocking from DataObjectTest.cpp This must land after the CL that adds WebBlobRegistry mocking to the Platform used by blink unit tests. CL: https://codereview.chromium.org/434833002 This change takes advantage of the CL above to remove the Platform mocking from the DataObject unit test. BUG=398366 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179451

Patch Set 1 : #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -125 lines) Patch
M Source/core/clipboard/DataObjectTest.cpp View 1 2 chunks +22 lines, -125 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pwnall-personal
I removed the mocking and added an extra test. What do you think?
6 years, 4 months ago (2014-08-01 01:55:09 UTC) #1
tkent
Looks cleaner!
6 years, 4 months ago (2014-08-01 03:40:18 UTC) #2
dcheng
lgtm. thanks for following up
6 years, 4 months ago (2014-08-01 06:37:01 UTC) #3
pwnall-personal
The CQ bit was checked by costan@gmail.com
6 years, 4 months ago (2014-08-03 02:33:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/434823002/40001
6 years, 4 months ago (2014-08-03 02:33:35 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-03 02:36:24 UTC) #6
Message was sent while issue was closed.
Change committed as 179451

Powered by Google App Engine
This is Rietveld 408576698