Add mock WebBlobRegistry to TestWebKitPlatformSupport.

Add mock WebBlobRegistry to TestWebKitPlatformSupport.

This is necessary for being able to test the File API, or code depending
on it, in the blink unit tests.

BUG=398366
TEST=no webkit_unit_tests crash in https://codereview.chromium.org/434823002/

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287200

[pwnall-personal, 2014-08-01 01:58:56]

This popped up in the post-review discussion for
https://codereview.chromium.org/423283003/

Can you please take a look?

[dcheng, 2014-08-01 06:35:31]

lgtm with some nits (though I am not an OWNER for this code)

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
File content/test/mock_webblob_registry_impl.cc (right):

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
content/test/mock_webblob_registry_impl.cc:35: void
MockWebBlobRegistryImpl::registerPublicBlobURL(const WebURL&,
const WebURL& url for consistency.

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
content/test/mock_webblob_registry_impl.cc:37: }
Newline after this.

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
content/test/mock_webblob_registry_impl.cc:38: void
MockWebBlobRegistryImpl::revokePublicBlobURL(const WebURL&) {
const WebURL& url for consistency.

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
File content/test/mock_webblob_registry_impl.h (right):

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
content/test/mock_webblob_registry_impl.h:16: }
None of these forward declares should be required.

https://codereview.chromium.org/434833002/diff/20001/content/test/test_webkit...
File content/test/test_webkit_platform_support.cc (right):

https://codereview.chromium.org/434833002/diff/20001/content/test/test_webkit...
content/test/test_webkit_platform_support.cc:139: 
Extra newline.

[dcheng, 2014-08-01 06:35:32]

lgtm with some nits (though I am not an OWNER for this code)

[jochen (gone - plz use gerrit), 2014-08-01 07:34:25]

lgtm

[pwnall-personal, 2014-08-01 20:37:47]

Thank you for the quick feedback! I'll watch out for trybot issues and then CQ
this.

https://codereview.chromium.org/434833002/diff/20001/content/child/webblobreg...
File content/child/webblobregistry_impl.h (right):

https://codereview.chromium.org/434833002/diff/20001/content/child/webblobreg...
content/child/webblobregistry_impl.h:5: #ifndef
CONTENT_CHILD_FILEAPI_WEBBLOBREGISTRY_IMPL_H_
I just realized that this define guard is incorrect, so I fixed it as well.

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
File content/test/mock_webblob_registry_impl.cc (right):

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
content/test/mock_webblob_registry_impl.cc:35: void
MockWebBlobRegistryImpl::registerPublicBlobURL(const WebURL&,
On 2014/08/01 06:35:31, dcheng (OOO) wrote:
> const WebURL& url for consistency.

Done.

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
content/test/mock_webblob_registry_impl.cc:37: }
On 2014/08/01 06:35:31, dcheng (OOO) wrote:
> Newline after this.

Done.

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
content/test/mock_webblob_registry_impl.cc:38: void
MockWebBlobRegistryImpl::revokePublicBlobURL(const WebURL&) {
On 2014/08/01 06:35:31, dcheng (OOO) wrote:
> const WebURL& url for consistency.

Done.

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
File content/test/mock_webblob_registry_impl.h (right):

https://codereview.chromium.org/434833002/diff/20001/content/test/mock_webblo...
content/test/mock_webblob_registry_impl.h:16: }
On 2014/08/01 06:35:31, dcheng (OOO) wrote:
> None of these forward declares should be required.

Done.
Thank you! Good point!
I also removed the forward declares from content/child/webblob_registry_impl.h

https://codereview.chromium.org/434833002/diff/20001/content/test/test_webkit...
File content/test/test_webkit_platform_support.cc (right):

https://codereview.chromium.org/434833002/diff/20001/content/test/test_webkit...
content/test/test_webkit_platform_support.cc:139: 
On 2014/08/01 06:35:31, dcheng (OOO) wrote:
> Extra newline.

Done.
Thank you!

[pwnall-personal, 2014-08-02 01:03:33]

The CQ bit was checked by costan@gmail.com

[commit-bot: I haz the power, 2014-08-02 01:05:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/costan@gmail.com/434833002/40001

[commit-bot: I haz the power, 2014-08-02 11:36:12]

Change committed as 287200