Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 434683002: Remove KeyboardEvent.altGraphKey (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-events_chromium.org, blink-reviews-html_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch
Project:
blink
Visibility:
Public.

Description

Remove KeyboardEvent.altGraphKey Added to WebKit in 2003: http://trac.webkit.org/changeset/5402 But never standardized: http://www.w3.org/TR/DOM-Level-3-Events/#interface-KeyboardEvent It is always false for real events in Chromium. Synthetic events can be created where it is true using initKeyboardEvent, which is also not per spec. Ad-hoc testing with document.createEvent('KeyboardEvent').altGraphKey shows that this attribute is not supported in IE11, Firefox Nightly or Opera 12.16, i.e. only WebKit ever added this. All in all, it seems very unlikely that content could depend on this, and thus the deprecation process is skipped. BUG=399451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -56 lines) Patch
M LayoutTests/fast/events/init-events-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/script-tests/init-events.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/tabs-with-modifiers.html View 2 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/forms/tabs-with-modifiers-expected.txt View 1 chunk +0 lines, -24 lines 0 comments Download
M Source/core/events/KeyboardEvent.h View 2 chunks +4 lines, -7 lines 0 comments Download
M Source/core/events/KeyboardEvent.cpp View 6 chunks +2 lines, -7 lines 0 comments Download
M Source/core/events/KeyboardEvent.idl View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/web/tests/WebInputEventConversionTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
philipj_slow
PTAL, this one seems trivial enough to avoid spamming blink-dev.
6 years, 4 months ago (2014-07-31 21:46:39 UTC) #1
Rick Byers
LGTM I agree this is very unlikely to be an issue and am fine skipping ...
6 years, 4 months ago (2014-08-01 13:02:03 UTC) #2
Rick Byers
On 2014/08/01 13:02:03, Rick Byers wrote: > LGTM > > I agree this is very ...
6 years, 4 months ago (2014-08-01 13:03:13 UTC) #3
philipj_slow
Ping eseidel
6 years, 4 months ago (2014-08-03 14:11:53 UTC) #4
philipj_slow
abarth, can you take a look? It's a bit similar to the webkitDirectionInvertedFromDevice case.
6 years, 4 months ago (2014-08-05 20:59:01 UTC) #5
abarth-chromium
lgtm
6 years, 4 months ago (2014-08-05 21:01:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/434683002/1
6 years, 4 months ago (2014-08-05 21:05:26 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-05 23:26:07 UTC) #8
Message was sent while issue was closed.
Change committed as 179545

Powered by Google App Engine
This is Rietveld 408576698