Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1344)

Unified Diff: Source/core/page/EventHandler.cpp

Issue 434683002: Remove KeyboardEvent.altGraphKey (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/web/tests/WebInputEventConversionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/EventHandler.cpp
diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp
index b4f31072eaa6af5b1cb784a00604521082f79817..a34859c85224959f572409f60dcff7bdcbb4eb96 100644
--- a/Source/core/page/EventHandler.cpp
+++ b/Source/core/page/EventHandler.cpp
@@ -3292,7 +3292,7 @@ void EventHandler::defaultSpaceEventHandler(KeyboardEvent* event)
{
ASSERT(event->type() == EventTypeNames::keypress);
- if (event->ctrlKey() || event->metaKey() || event->altKey() || event->altGraphKey())
+ if (event->ctrlKey() || event->metaKey() || event->altKey())
return;
ScrollDirection direction = event->shiftKey() ? ScrollBlockDirectionBackward : ScrollBlockDirectionForward;
@@ -3313,7 +3313,7 @@ void EventHandler::defaultBackspaceEventHandler(KeyboardEvent* event)
{
ASSERT(event->type() == EventTypeNames::keydown);
- if (event->ctrlKey() || event->metaKey() || event->altKey() || event->altGraphKey())
+ if (event->ctrlKey() || event->metaKey() || event->altKey())
return;
if (!m_frame->editor().behavior().shouldNavigateBackOnBackspace())
@@ -3331,7 +3331,7 @@ void EventHandler::defaultArrowEventHandler(FocusType focusType, KeyboardEvent*
{
ASSERT(event->type() == EventTypeNames::keydown);
- if (event->ctrlKey() || event->metaKey() || event->altGraphKey() || event->shiftKey())
+ if (event->ctrlKey() || event->metaKey() || event->shiftKey())
return;
Page* page = m_frame->page();
@@ -3355,7 +3355,7 @@ void EventHandler::defaultTabEventHandler(KeyboardEvent* event)
ASSERT(event->type() == EventTypeNames::keydown);
// We should only advance focus on tabs if no special modifier keys are held down.
- if (event->ctrlKey() || event->metaKey() || event->altGraphKey())
+ if (event->ctrlKey() || event->metaKey())
return;
Page* page = m_frame->page();
« no previous file with comments | « Source/core/html/HTMLSelectElement.cpp ('k') | Source/web/tests/WebInputEventConversionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698