Issue 434553002: [arm] Add support for ROR. Refactor operand2 handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 434553002: [arm] Add support for ROR. Refactor operand2 handling. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Sven Panne, Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[arm] Add support for ROR. Refactor operand2 handling. This was the last missing bit for full "flexible second operand" / operand2 support on ARM. TEST=cctest/test-instruction-selector-arm,cctest/test-run-machops R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22732

Patch Set 1 : #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+638 lines, -118 lines)			Patch
M	src/compiler/arm/code-generator-arm.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	src/compiler/arm/instruction-codes-arm.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/compiler/arm/instruction-selector-arm.cc	View	7 chunks	+206 lines, -113 lines	0 comments	Download
M	test/cctest/compiler/codegen-tester.h	View	2 chunks	+30 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-instruction-selector-arm.cc	View	4 chunks	+334 lines, -0 lines	0 comments	Download
M	test/cctest/compiler/test-run-machops.cc	View	2 chunks	+48 lines, -1 line	0 comments	Download
M	test/cctest/compiler/value-helper.h	View	2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 4 months ago (2014-07-31 07:44:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22732 (tree was closed).

Expand Messages | Collapse Messages