Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: Source/bindings/scripts/generate_global_constructors.py

Issue 434133002: Support WebIDL's ExtendedAttributeIdentList in the Blink parser (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/compute_global_objects.py ('k') | Source/bindings/scripts/idl_validator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/generate_global_constructors.py
diff --git a/Source/bindings/scripts/generate_global_constructors.py b/Source/bindings/scripts/generate_global_constructors.py
index 81838fe1865d5f819eaa9e7bdd41e2bd458584bc..1be2ac3327c730f529759f552f658bfeff42f7c5 100755
--- a/Source/bindings/scripts/generate_global_constructors.py
+++ b/Source/bindings/scripts/generate_global_constructors.py
@@ -86,9 +86,7 @@ def record_global_constructors(idl_filename):
# member the extended attribute applies to will be exposed only on objects
# associated with ECMAScript global environments whose global object
# implements an interface that has a matching global name.
- # FIXME: In spec names are comma-separated, but that makes parsing very
- # difficult (https://www.w3.org/Bugs/Public/show_bug.cgi?id=24959).
- exposed_global_names = extended_attributes.get('Exposed', 'Window').split('&')
+ exposed_global_names = extended_attributes.get('Exposed', 'Window').strip('()').split(',')
new_constructors_list = generate_global_constructors_list(interface_name, extended_attributes)
for exposed_global_name in exposed_global_names:
global_name_to_constructors[exposed_global_name].extend(new_constructors_list)
« no previous file with comments | « Source/bindings/scripts/compute_global_objects.py ('k') | Source/bindings/scripts/idl_validator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698