Source/bindings/scripts/compute_global_objects.py - Issue 434133002: Support WebIDL's ExtendedAttributeIdentList in the Blink parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/compute_global_objects.py

Issue 434133002: Support WebIDL's ExtendedAttributeIdentList in the Blink parser (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/compute_global_objects.py

diff --git a/Source/bindings/scripts/compute_global_objects.py b/Source/bindings/scripts/compute_global_objects.py

index 93d2eed5db3d4e7f505fc2bf722938a395152fcd..2e83e466ef0803abebed04b9343a8cedf623f623 100755

--- a/Source/bindings/scripts/compute_global_objects.py

+++ b/Source/bindings/scripts/compute_global_objects.py

@@ -73,9 +73,7 @@ def idl_file_to_global_names(idl_filename):

global_value = extended_attributes[global_key]

if global_value:

- # FIXME: In spec names are comma-separated, which makes parsing very

- # difficult (https://www.w3.org/Bugs/Public/show_bug.cgi?id=24959).

- return global_value.split('&')

+ return global_value.strip('()').split(',')

return [interface_name]