Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 433903004: DelegatedFrameHost: drop renderer frame on resize if hidden (Closed)

Created:
6 years, 4 months ago by piman
Modified:
6 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

DelegatedFrameHost: drop renderer frame on resize if hidden No point in keeping memory around for a frame we don't care about. BUG=399071, 399420 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287811

Patch Set 1 : . #

Patch Set 2 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/compositor/delegated_frame_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
piman
Note: this needs something like https://codereview.chromium.org/422683007/ to be effective on Aura.
6 years, 4 months ago (2014-08-05 22:34:54 UTC) #1
danakj
LGTM!
6 years, 4 months ago (2014-08-06 14:07:01 UTC) #2
piman
The CQ bit was checked by piman@chromium.org
6 years, 4 months ago (2014-08-06 17:07:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/433903004/40001
6 years, 4 months ago (2014-08-06 17:08:31 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 18:36:18 UTC) #5
Message was sent while issue was closed.
Change committed as 287811

Powered by Google App Engine
This is Rietveld 408576698