Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2164)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 433903004: DelegatedFrameHost: drop renderer frame on resize if hidden (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/compositor/delegated_frame_host.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 4d1263d4de8b2a67544fd9df0e176e0590f6760c..49f017879e0281cd0663b6f2a41321aca12f4ed6 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -1575,6 +1575,19 @@ TEST_F(RenderWidgetHostViewAuraTest, DiscardDelegatedFrames) {
views[0]->WasHidden();
EXPECT_FALSE(views[0]->released_front_lock_active());
+ // Make [1] hidden, resize it. It should drop its frame.
+ views[1]->WasHidden();
+ EXPECT_TRUE(views[1]->frame_provider());
+ gfx::Size size2(200, 200);
+ views[1]->SetSize(size2);
+ EXPECT_FALSE(views[1]->frame_provider());
+ // Show it, it should block until we give it a frame.
+ views[1]->WasShown();
+ EXPECT_TRUE(views[1]->released_front_lock_active());
+ views[1]->OnSwapCompositorFrame(
+ 1, MakeDelegatedFrame(1.f, size2, gfx::Rect(size2)));
+ EXPECT_FALSE(views[1]->released_front_lock_active());
+
for (size_t i = 0; i < renderer_count - 1; ++i)
views[i]->WasHidden();
« no previous file with comments | « content/browser/compositor/delegated_frame_host.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698