Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 433483003: Remove isFinish parameter from onImeEvent() method in ImeAdapterDelegate interface (Closed)

Created:
6 years, 4 months ago by ams
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove isFinish parameter from onImeEvent() method in ImeAdapterDelegate |isFinish| was introduced to notify finish composition when it is set to true. However currently it is never set to true as finish composition flow has changed. Also there is no consumer for isFinish = true. Hence removing this parameter from onImeEvent(). BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286745

Patch Set 1 #

Patch Set 2 : Adding AdapterInputConnectionTest.java modifications #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -13 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +2 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 4 chunks +6 lines, -8 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/input/AdapterInputConnectionTest.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
ams
@jdduke, @aurimas, PTAL
6 years, 4 months ago (2014-07-30 15:35:33 UTC) #1
aurimas (slooooooooow)
lgtm
6 years, 4 months ago (2014-07-30 17:39:35 UTC) #2
jdduke (slow)
On 2014/07/30 17:39:35, aurimas wrote: > lgtm rubber stamp lgtm
6 years, 4 months ago (2014-07-30 17:41:14 UTC) #3
ams
The CQ bit was checked by amit.srkr@samsung.com
6 years, 4 months ago (2014-07-30 18:54:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amit.srkr@samsung.com/433483003/1
6 years, 4 months ago (2014-07-30 18:57:26 UTC) #5
ams
On 2014/07/30 17:41:14, jdduke wrote: > On 2014/07/30 17:39:35, aurimas wrote: > > lgtm > ...
6 years, 4 months ago (2014-07-30 19:01:02 UTC) #6
ams
The CQ bit was unchecked by amit.srkr@samsung.com
6 years, 4 months ago (2014-07-30 19:18:10 UTC) #7
ams
On 2014/07/30 19:18:10, ams wrote: > The CQ bit was unchecked by mailto:amit.srkr@samsung.com I found ...
6 years, 4 months ago (2014-07-30 19:24:26 UTC) #8
ams
On 2014/07/30 19:24:26, ams wrote: > On 2014/07/30 19:18:10, ams wrote: > > The CQ ...
6 years, 4 months ago (2014-07-31 05:09:11 UTC) #9
aurimas (slooooooooow)
Still LGTM
6 years, 4 months ago (2014-07-31 05:20:54 UTC) #10
ams
The CQ bit was checked by amit.srkr@samsung.com
6 years, 4 months ago (2014-07-31 05:42:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/amit.srkr@samsung.com/433483003/20001
6 years, 4 months ago (2014-07-31 05:43:17 UTC) #12
commit-bot: I haz the power
6 years, 4 months ago (2014-07-31 11:56:01 UTC) #13
Message was sent while issue was closed.
Change committed as 286745

Powered by Google App Engine
This is Rietveld 408576698