content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 433483003: Remove isFinish parameter from onImeEvent() method in ImeAdapterDelegate interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 433483003: Remove isFinish parameter from onImeEvent() method in ImeAdapterDelegate interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding AdapterInputConnectionTest.java modifications Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 655be6a7c7b82ab67db6a095193209f122d00684..935e35db608a52732d4db3fbeac926cbcab4070e 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -553,14 +553,12 @@ public class ContentViewCore

return new ImeAdapter(mInputMethodManagerWrapper,

new ImeAdapter.ImeAdapterDelegate() {

@Override

- public void onImeEvent(boolean isFinish) {

+ public void onImeEvent() {

if (mPopupZoomer.isShowing()) {

mPopupZoomer.hide(true);

}

getContentViewClient().onImeEvent();

- if (!isFinish) {

- hideTextHandles();

- }

+ hideTextHandles();

}

@Override

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | no next file with comments »