Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 433433002: Remove code for the old Web Notification permission-path. (Closed)

Created:
6 years, 4 months ago by Peter Beverloo
Modified:
6 years, 4 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, nasko+codewatch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove code for the old Web Notification permission-path. CL 393863002 switched Blink over to the new permission path for Web Notifications, eliminating a synchronous IPC message and allowing the rest of Web Notifications to be separated from WebFrame. Remove the now unused code. BUG=392187, 398045 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287753

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -99 lines) Patch
M content/browser/frame_host/render_frame_host_impl.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 3 chunks +0 lines, -22 lines 0 comments Download
M content/common/desktop_notification_messages.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/active_notification_tracker.h View 2 chunks +1 line, -12 lines 0 comments Download
M content/renderer/active_notification_tracker.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/renderer/notification_provider.h View 2 chunks +0 lines, -7 lines 0 comments Download
M content/renderer/notification_provider.cc View 5 chunks +0 lines, -21 lines 0 comments Download
M content/shell/renderer/test_runner/notification_presenter.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/notification_presenter.cc View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Peter Beverloo
This patch depends on the Blink patch to enable the new path: https://codereview.chromium.org/393863002/ (It should ...
6 years, 4 months ago (2014-07-30 13:17:07 UTC) #1
Peter Beverloo
+palmer for IPC
6 years, 4 months ago (2014-07-30 13:17:24 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 4 months ago (2014-07-30 13:47:58 UTC) #3
palmer
lgtm
6 years, 4 months ago (2014-08-05 01:17:59 UTC) #4
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 4 months ago (2014-08-05 18:52:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/433433002/20001
6 years, 4 months ago (2014-08-05 18:54:06 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-05 22:43:07 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 00:13:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/3215)
6 years, 4 months ago (2014-08-06 00:13:17 UTC) #9
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 4 months ago (2014-08-06 00:23:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/433433002/20001
6 years, 4 months ago (2014-08-06 00:25:32 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-06 01:29:41 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-06 02:59:06 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/3286)
6 years, 4 months ago (2014-08-06 02:59:08 UTC) #14
Peter Beverloo
The CQ bit was checked by peter@chromium.org
6 years, 4 months ago (2014-08-06 09:57:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peter@chromium.org/433433002/20001
6 years, 4 months ago (2014-08-06 09:59:25 UTC) #16
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 10:47:01 UTC) #17
Message was sent while issue was closed.
Change committed as 287753

Powered by Google App Engine
This is Rietveld 408576698