Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 433433002: Remove code for the old Web Notification permission-path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/common/desktop_notification_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 5487a5ef8103e2e4f8b73eeb2b5a45780937332c..23c965e8b453c67623692f4e3641cc412c00674a 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -350,8 +350,6 @@ bool RenderFrameHostImpl::OnMessageReceived(const IPC::Message &msg) {
OnBeginNavigation)
IPC_MESSAGE_HANDLER(PlatformNotificationHostMsg_RequestPermission,
OnRequestPlatformNotificationPermission)
- IPC_MESSAGE_HANDLER(DesktopNotificationHostMsg_RequestPermission,
- OnRequestDesktopNotificationPermission)
IPC_MESSAGE_HANDLER(DesktopNotificationHostMsg_Show,
OnShowDesktopNotification)
IPC_MESSAGE_HANDLER(DesktopNotificationHostMsg_Cancel,
@@ -841,19 +839,6 @@ void RenderFrameHostImpl::OnRequestPlatformNotificationPermission(
origin, this, done_callback);
}
-// TODO(peter): Remove this call and the associated IPC messages when Blink
-// has switched to the new Web Notification permission code-path.
-void RenderFrameHostImpl::OnRequestDesktopNotificationPermission(
- const GURL& source_origin, int callback_context) {
- base::Callback<void(blink::WebNotificationPermission)> done_callback =
- base::Bind(&RenderFrameHostImpl::DesktopNotificationPermissionRequestDone,
- weak_ptr_factory_.GetWeakPtr(),
- callback_context);
-
- GetContentClient()->browser()->RequestDesktopNotificationPermission(
- source_origin, this, done_callback);
-}
-
void RenderFrameHostImpl::OnShowDesktopNotification(
int notification_id,
const ShowDesktopNotificationHostMsgParams& params) {
@@ -1163,13 +1148,6 @@ void RenderFrameHostImpl::PlatformNotificationPermissionRequestDone(
routing_id_, request_id, permission));
}
-// TODO(peter): Remove this method when Blink uses the new code-path.
-void RenderFrameHostImpl::DesktopNotificationPermissionRequestDone(
- int callback_context, blink::WebNotificationPermission permission) {
- Send(new DesktopNotificationMsg_PermissionRequestDone(
- routing_id_, callback_context));
-}
-
void RenderFrameHostImpl::SetAccessibilityMode(AccessibilityMode mode) {
Send(new FrameMsg_SetAccessibilityMode(routing_id_, mode));
}
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/common/desktop_notification_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698