chrome/browser/chromeos/input_method/mock_input_method_engine.h - Issue 433163005: Refactoring for InputMethodEngine and InputMethodEventRouter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/mock_input_method_engine.h

Issue 433163005: Refactoring for InputMethodEngine and InputMethodEventRouter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('K') | « chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc ('k') | chrome/browser/chromeos/input_method/mock_input_method_engine.cc » ('j') | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/mock_input_method_engine.h

diff --git a/chrome/browser/chromeos/input_method/mock_input_method_engine.h b/chrome/browser/chromeos/input_method/mock_input_method_engine.h

index c22ac5d56d20e1c6a4de67da6e769f9b02804673..5d8810bd713e2f1f8df498d7e41154dd6b05b968 100644

--- a/chrome/browser/chromeos/input_method/mock_input_method_engine.h

+++ b/chrome/browser/chromeos/input_method/mock_input_method_engine.h

@@ -32,14 +32,11 @@ struct KeyEventHandle;

class MockInputMethodEngine : public InputMethodEngineInterface {

public:

- explicit MockInputMethodEngine(

- const input_method::InputMethodDescriptor& descriptor);

+ explicit MockInputMethodEngine();

virtual ~MockInputMethodEngine();

// InputMethodEngineInterface overrides.

- virtual const input_method::InputMethodDescriptor& GetDescriptor()

- const OVERRIDE;

- virtual void NotifyImeReady() OVERRIDE;

+ virtual const std::string& GetActiveEngineId() const OVERRIDE;

virtual bool SetComposition(int context_id,

const char* text,

int selection_start,

@@ -75,7 +72,7 @@ class MockInputMethodEngine : public InputMethodEngineInterface {

virtual void FocusIn(

const IMEEngineHandlerInterface::InputContext& input_context) OVERRIDE;

virtual void FocusOut() OVERRIDE;

- virtual void Enable() OVERRIDE;

+ virtual void Enable(const std::string& engine_id) OVERRIDE;

virtual void Disable() OVERRIDE;

virtual void PropertyActivate(const std::string& property_name) OVERRIDE;

virtual void Reset() OVERRIDE;

@@ -91,8 +88,7 @@ class MockInputMethodEngine : public InputMethodEngineInterface {

}

private:

- // Descriptor of this input method.

- input_method::InputMethodDescriptor descriptor_;

+ std::string active_engine_id_;

// The current candidate window property.

CandidateWindowProperty candidate_window_property_;