chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc - Issue 433163005: Refactoring for InputMethodEngine and InputMethodEventRouter.

Unified Diff: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

Issue 433163005: Refactoring for InputMethodEngine and InputMethodEventRouter. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('K') | « chrome/browser/chromeos/input_method/input_method_manager_impl.cc ('k') | chrome/browser/chromeos/input_method/mock_input_method_engine.h » ('j') | chrome/browser/extensions/api/input_ime/input_ime_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

index a1a4ad82f0939820a8be13734dc622ab4cc12a99..e1eb24d412cb0b3a59163d0ae066020175353e85 100644

--- a/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

+++ b/chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc

@@ -43,6 +43,8 @@ const char kNaclMozcJpId[] = "nacl_mozc_jp";

const char kExt2Engine1Id[] = "ext2_engine1-t-i0-engine_id";

const char kExt2Engine2Id[] = "ext2_engine2-t-i0-engine_id";

const char kPinyinImeId[] = "zh-t-i0-pinyin";

+const char kExtensionId1[] = "00000000000000000000000000000000";

+const char kExtensionId2[] = "11111111111111111111111111111111";

// Returns true if |descriptors| contain |target|.

bool Contain(const InputMethodDescriptors& descriptors,

@@ -82,8 +84,7 @@ class InputMethodManagerImplTest : public BrowserWithTestWindowTest {

candidate_window_controller_);

keyboard_ = new FakeImeKeyboard;

manager_->SetImeKeyboardForTesting(keyboard_);

- mock_engine_handler_.reset(

- new MockInputMethodEngine(InputMethodDescriptor()));

+ mock_engine_handler_.reset(new MockInputMethodEngine());

IMEBridge::Initialize();

IMEBridge::Get()->SetCurrentEngineHandler(mock_engine_handler_.get());

@@ -114,16 +115,20 @@ class InputMethodManagerImplTest : public BrowserWithTestWindowTest {

mock_delegate_->set_ime_list(ime_list_);

scoped_ptr<ComponentExtensionIMEManagerDelegate> delegate(mock_delegate_);

+ std::vector<std::string> layouts;

+ layouts.push_back("us");

+ std::vector<std::string> languages;

+ languages.push_back("en-US");

// Note, for production, these SetEngineHandler are called when

// IMEEngineHandlerInterface is initialized via

// InitializeComponentextension.

+ InputMethodDescriptors descriptors;

manager_->AddInputMethodExtension(ImeIdFromEngineId(kNaclMozcUsId),

- mock_engine_handler_.get());

- manager_->AddInputMethodExtension(ImeIdFromEngineId(kNaclMozcJpId),

+ descriptors,

mock_engine_handler_.get());

manager_->AddInputMethodExtension(ImeIdFromEngineId(kExt2Engine1Id),

- mock_engine_handler_.get());

- manager_->AddInputMethodExtension(ImeIdFromEngineId(kExt2Engine2Id),

+ descriptors,

mock_engine_handler_.get());

manager_->InitializeComponentExtensionForTesting(delegate.Pass());

}

@@ -1119,7 +1124,7 @@ TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {

languages.push_back("en-US");

const std::string ext1_id =

- extension_ime_util::GetInputMethodID("deadbeef", "engine_id");

+ extension_ime_util::GetInputMethodID(kExtensionId1, "engine_id");

const InputMethodDescriptor descriptor1(ext1_id,

"deadbeef input method",

"DB",

@@ -1128,8 +1133,10 @@ TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {

false, // is_login_keyboard

GURL(),

GURL());

- MockInputMethodEngine engine(descriptor1);

- manager_->AddInputMethodExtension(ext1_id, &engine);

+ MockInputMethodEngine engine;

+ InputMethodDescriptors descriptors;

+ descriptors.push_back(descriptor1);

+ manager_->AddInputMethodExtension(kExtensionId1, descriptors, &engine);

// Extension IMEs are not enabled by default.

EXPECT_EQ(1U, manager_->GetNumActiveInputMethods());

@@ -1148,7 +1155,7 @@ TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {

}

const std::string ext2_id =

- extension_ime_util::GetInputMethodID("cafebabe", "engine_id");

+ extension_ime_util::GetInputMethodID(kExtensionId2, "engine_id");

const InputMethodDescriptor descriptor2(ext2_id,

"cafebabe input method",

"CB",

@@ -1157,8 +1164,10 @@ TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {

false, // is_login_keyboard

GURL(),

GURL());

- MockInputMethodEngine engine2(descriptor2);

- manager_->AddInputMethodExtension(ext2_id, &engine2);

+ descriptors.clear();

+ descriptors.push_back(descriptor2);

+ MockInputMethodEngine engine2;

+ manager_->AddInputMethodExtension(kExtensionId2, descriptors, &engine2);

EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());

extension_ime_ids.push_back(ext2_id);

@@ -1174,9 +1183,9 @@ TEST_F(InputMethodManagerImplTest, TestAddRemoveExtensionInputMethods) {

}

// Remove them.

- manager_->RemoveInputMethodExtension(ext1_id);

+ manager_->RemoveInputMethodExtension(kExtensionId1);

EXPECT_EQ(2U, manager_->GetNumActiveInputMethods());

- manager_->RemoveInputMethodExtension(ext2_id);

+ manager_->RemoveInputMethodExtension(kExtensionId2);

EXPECT_EQ(1U, manager_->GetNumActiveInputMethods());

}

@@ -1200,7 +1209,7 @@ TEST_F(InputMethodManagerImplTest, TestAddExtensionInputThenLockScreen) {

languages.push_back("en-US");

const std::string ext_id =

- extension_ime_util::GetInputMethodID("deadbeef", "engine_id");

+ extension_ime_util::GetInputMethodID(kExtensionId1, "engine_id");

const InputMethodDescriptor descriptor(ext_id,

"deadbeef input method",

"DB",

@@ -1209,8 +1218,10 @@ TEST_F(InputMethodManagerImplTest, TestAddExtensionInputThenLockScreen) {

false, // is_login_keyboard

GURL(),

GURL());

- MockInputMethodEngine engine(descriptor);

- manager_->AddInputMethodExtension(ext_id, &engine);

+ MockInputMethodEngine engine;

+ InputMethodDescriptors descriptors;

+ descriptors.push_back(descriptor);

+ manager_->AddInputMethodExtension(kExtensionId1, descriptors, &engine);

// Extension IME is not enabled by default.

EXPECT_EQ(1U, manager_->GetNumActiveInputMethods());